content/public/common/content_client.h - Issue 1654193002: Include a role description string in node info for Android accessibility.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/common/content_client.h

Issue 1654193002: Include a role description string in node info for Android accessibility. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Lollipop should extend KitKat Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/android/java/src/org/chromium/content/browser/accessibility/LollipopBrowserAccessibilityManager.java ('K') | « content/public/android/java/src/org/chromium/content/browser/accessibility/LollipopBrowserAccessibilityManager.java ('k') | content/public/common/content_client.cc » ('j') | content/test/data/accessibility/html/heading-expected-android.txt » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/common/content_client.h

diff --git a/content/public/common/content_client.h b/content/public/common/content_client.h

index 9d51d5ba83d4cf5a458f84137d963d39063c7c40..2ef3fdc43a5e559444524a73dd6009e3269532ce 100644

--- a/content/public/common/content_client.h

+++ b/content/public/common/content_client.h

@@ -106,6 +106,12 @@ class CONTENT_EXPORT ContentClient {

// Returns a string resource given its id.

virtual base::string16 GetLocalizedString(int message_id) const;

+ // Returns a string resource given its id, and additionally replace

+ // $0 with |string0| and $$ with $.

+ virtual base::string16 GetLocalizedStringF(

+ int message_id,

+ const base::string16& string0) const;

David Tseng 2016/02/02 18:38:57 Is it worth it to make this take any number of str

dmazzoni 2016/02/03 17:55:07 Not sure, I'll ask the owners. I lean towards the

// Return the contents of a resource in a StringPiece given the resource id.

virtual base::StringPiece GetDataResource(

int resource_id,