Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

Issue 1654193002: Include a role description string in node info for Android accessibility. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update all Android test expectations Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java b/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
index 1f1a5f8f989d3d3ccbf2d1e0d8d066c87987edf9..629b9d68e00bc091f53d032ac00d75dcb66882c6 100644
--- a/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
+++ b/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
@@ -75,6 +75,9 @@ public class BrowserAccessibilityManager {
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
return new LollipopBrowserAccessibilityManager(
nativeBrowserAccessibilityManagerAndroid, contentViewCore);
+ } else if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) {
+ return new KitKatBrowserAccessibilityManager(
+ nativeBrowserAccessibilityManagerAndroid, contentViewCore);
} else {
return new BrowserAccessibilityManager(
nativeBrowserAccessibilityManagerAndroid, contentViewCore);
@@ -856,6 +859,12 @@ public class BrowserAccessibilityManager {
}
@CalledByNative
+ protected void setAccessibilityNodeInfoKitKatAttributes(AccessibilityNodeInfo node,
+ String roleDescription) {
+ // Requires KitKat or higher.
+ }
+
+ @CalledByNative
protected void setAccessibilityNodeInfoLollipopAttributes(AccessibilityNodeInfo node,
boolean canOpenPopup,
boolean contentInvalid,

Powered by Google App Engine
This is Rietveld 408576698