Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: content/browser/accessibility/accessibility_tree_formatter_android.cc

Issue 1654193002: Include a role description string in node info for Android accessibility. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update all Android test expectations Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/accessibility_tree_formatter_android.cc
diff --git a/content/browser/accessibility/accessibility_tree_formatter_android.cc b/content/browser/accessibility/accessibility_tree_formatter_android.cc
index 12321df619d0886d3343d298894ccbae43c4c798..24fce4d93ce590360630f14321308e8dda764c4a 100644
--- a/content/browser/accessibility/accessibility_tree_formatter_android.cc
+++ b/content/browser/accessibility/accessibility_tree_formatter_android.cc
@@ -127,6 +127,7 @@ void AccessibilityTreeFormatterAndroid::AddProperties(
// String attributes.
dict->SetString("name", android_node->GetText());
+ dict->SetString("role_description", android_node->GetRoleDescription());
// Int attributes.
dict->SetInteger("item_index", android_node->GetItemIndex());
@@ -171,6 +172,15 @@ base::string16 AccessibilityTreeFormatterAndroid::ToString(
dict.GetString("class", &class_value);
WriteAttribute(true, base::UTF16ToUTF8(class_value), &line);
+ std::string role_description;
+ dict.GetString("role_description", &role_description);
+ if (!role_description.empty()) {
+ WriteAttribute(
+ true,
+ StringPrintf("role_description='%s'", role_description.c_str()),
+ &line);
+ }
+
for (unsigned i = 0; i < arraysize(BOOL_ATTRIBUTES); i++) {
const char* attribute_name = BOOL_ATTRIBUTES[i];
bool value;
« no previous file with comments | « content/app/strings/content_strings.grd ('k') | content/browser/accessibility/browser_accessibility_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698