content/browser/accessibility/browser_accessibility_cocoa.mm - Issue 1654193002: Include a role description string in node info for Android accessibility.

Side by Side Diff: content/browser/accessibility/browser_accessibility_cocoa.mm

Issue 1654193002: Include a role description string in node info for Android accessibility. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Lollipop should extend KitKat Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/accessibility/browser_accessibility_android.cc ('K') | « content/browser/accessibility/browser_accessibility_android.cc ('k') | content/browser/accessibility/browser_accessibility_manager_android.cc » ('j') | content/public/android/java/src/org/chromium/content/browser/accessibility/LollipopBrowserAccessibilityManager.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include <execinfo.h>	5 #include <execinfo.h>

6 #include <stddef.h>	6 #include <stddef.h>

7 #include <stdint.h>	7 #include <stdint.h>

8	8

9 #import "content/browser/accessibility/browser_accessibility_cocoa.h"	9 #import "content/browser/accessibility/browser_accessibility_cocoa.h"

10	10

(...skipping 995 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1006 return base::SysUTF16ToNSString(content_client->GetLocalizedString(	1006 return base::SysUTF16ToNSString(content_client->GetLocalizedString(

1007 IDS_AX_ROLE_BANNER));	1007 IDS_AX_ROLE_BANNER));

1008 case ui::AX_ROLE_CHECK_BOX:	1008 case ui::AX_ROLE_CHECK_BOX:

1009 return base::SysUTF16ToNSString(content_client->GetLocalizedString(	1009 return base::SysUTF16ToNSString(content_client->GetLocalizedString(

1010 IDS_AX_ROLE_CHECK_BOX));	1010 IDS_AX_ROLE_CHECK_BOX));

1011 case ui::AX_ROLE_COMPLEMENTARY:	1011 case ui::AX_ROLE_COMPLEMENTARY:

1012 return base::SysUTF16ToNSString(content_client->GetLocalizedString(	1012 return base::SysUTF16ToNSString(content_client->GetLocalizedString(

1013 IDS_AX_ROLE_COMPLEMENTARY));	1013 IDS_AX_ROLE_COMPLEMENTARY));

1014 case ui::AX_ROLE_CONTENT_INFO:	1014 case ui::AX_ROLE_CONTENT_INFO:

1015 return base::SysUTF16ToNSString(content_client->GetLocalizedString(	1015 return base::SysUTF16ToNSString(content_client->GetLocalizedString(

1016 IDS_AX_ROLE_ADDRESS));	1016 IDS_AX_ROLE_CONTENT_INFO));
	David Tseng 2016/02/02 18:38:57 Got it (regarding removal in grd). Got it (regarding removal in grd). dmazzoni 2016/02/03 17:55:07 Acknowledged. Show quoted text On 2016/02/02 18:38:57, David Tseng wrote: > Got it (regarding removal in grd). Acknowledged.
1017 case ui::AX_ROLE_DESCRIPTION_LIST:	1017 case ui::AX_ROLE_DESCRIPTION_LIST:

1018 return base::SysUTF16ToNSString(content_client->GetLocalizedString(	1018 return base::SysUTF16ToNSString(content_client->GetLocalizedString(

1019 IDS_AX_ROLE_DESCRIPTION_LIST));	1019 IDS_AX_ROLE_DESCRIPTION_LIST));

1020 case ui::AX_ROLE_DESCRIPTION_LIST_DETAIL:	1020 case ui::AX_ROLE_DESCRIPTION_LIST_DETAIL:

1021 return base::SysUTF16ToNSString(content_client->GetLocalizedString(	1021 return base::SysUTF16ToNSString(content_client->GetLocalizedString(

1022 IDS_AX_ROLE_DESCRIPTION_DETAIL));	1022 IDS_AX_ROLE_DESCRIPTION_DETAIL));

1023 case ui::AX_ROLE_DESCRIPTION_LIST_TERM:	1023 case ui::AX_ROLE_DESCRIPTION_LIST_TERM:

1024 return base::SysUTF16ToNSString(content_client->GetLocalizedString(	1024 return base::SysUTF16ToNSString(content_client->GetLocalizedString(

1025 IDS_AX_ROLE_DESCRIPTION_TERM));	1025 IDS_AX_ROLE_DESCRIPTION_TERM));

1026 case ui::AX_ROLE_FIGURE:	1026 case ui::AX_ROLE_FIGURE:

(...skipping 1055 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
2082 if (!browserAccessibility_)	2082 if (!browserAccessibility_)

2083 return [super hash];	2083 return [super hash];

2084 return browserAccessibility_->GetId();	2084 return browserAccessibility_->GetId();

2085 }	2085 }

2086	2086

2087 - (BOOL)accessibilityShouldUseUniqueId {	2087 - (BOOL)accessibilityShouldUseUniqueId {

2088 return YES;	2088 return YES;

2089 }	2089 }

2090	2090

2091 @end	2091 @end

OLD	NEW