content/browser/accessibility/browser_accessibility_android.h - Issue 1654193002: Include a role description string in node info for Android accessibility.

Side by Side Diff: content/browser/accessibility/browser_accessibility_android.h

Issue 1654193002: Include a role description string in node info for Android accessibility. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Lollipop should extend KitKat Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/app/strings/content_strings.grd ('K') | « content/browser/accessibility/accessibility_tree_formatter_android.cc ('k') | content/browser/accessibility/browser_accessibility_android.cc » ('j') | content/browser/accessibility/browser_accessibility_android.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_ANDROID_H_	5 #ifndef CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_ANDROID_H_

6 #define CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_ANDROID_H_	6 #define CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_ANDROID_H_

7	7

8 #include <stddef.h>	8 #include <stddef.h>

9 #include <stdint.h>	9 #include <stdint.h>

10	10

(...skipping 34 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
45 bool IsSlider() const;	45 bool IsSlider() const;

46 bool IsVisibleToUser() const;	46 bool IsVisibleToUser() const;

47	47

48 bool CanOpenPopup() const;	48 bool CanOpenPopup() const;

49	49

50 bool HasFocusableChild() const;	50 bool HasFocusableChild() const;

51	51

52 const char* GetClassName() const;	52 const char* GetClassName() const;

53 base::string16 GetText() const override;	53 base::string16 GetText() const override;

54	54

	55 base::string16 GetRoleDescription() const;
	David Tseng 2016/02/02 18:38:57 const base::string16& const base::string16& dmazzoni 2016/02/03 17:55:07 Can't do that because the function doesn't just re Show quoted text On 2016/02/02 18:38:57, David Tseng wrote: > const base::string16& Can't do that because the function doesn't just return a reference to an existing string of global scope, it returns a string object.
	56

55 int GetItemIndex() const;	57 int GetItemIndex() const;

56 int GetItemCount() const;	58 int GetItemCount() const;

57	59

58 bool CanScrollForward() const;	60 bool CanScrollForward() const;

59 bool CanScrollBackward() const;	61 bool CanScrollBackward() const;

60 bool CanScrollUp() const;	62 bool CanScrollUp() const;

61 bool CanScrollDown() const;	63 bool CanScrollDown() const;

62 bool CanScrollLeft() const;	64 bool CanScrollLeft() const;

63 bool CanScrollRight() const;	65 bool CanScrollRight() const;

64 int GetScrollX() const;	66 int GetScrollX() const;

(...skipping 74 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
139 bool first_time_;	141 bool first_time_;

140 base::string16 old_value_;	142 base::string16 old_value_;

141 base::string16 new_value_;	143 base::string16 new_value_;

142	144

143 DISALLOW_COPY_AND_ASSIGN(BrowserAccessibilityAndroid);	145 DISALLOW_COPY_AND_ASSIGN(BrowserAccessibilityAndroid);

144 };	146 };

145	147

146 } // namespace content	148 } // namespace content

147	149

148 #endif // CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_ANDROID_H_	150 #endif // CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_ANDROID_H_

OLD	NEW