Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: test/runner/runner_test.dart

Issue 1654183003: Fix tests that use a 0-length timeout. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/runner/pause_after_load_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/runner/runner_test.dart
diff --git a/test/runner/runner_test.dart b/test/runner/runner_test.dart
index 8a69547cb25321cdd2c3b2616dabf1a0bed0b8d1..493f8b621fc27e06dcab8029be5ed6db8f873da2 100644
--- a/test/runner/runner_test.dart
+++ b/test/runner/runner_test.dart
@@ -402,8 +402,11 @@ import 'dart:async';
import 'package:test/test.dart';
void main() {
- test("fail", () => throw 'oh no', onPlatform: {
- "vm": new Timeout(new Duration(seconds: 0))
+ test("fail", () async {
+ await new Future.delayed(Duration.ZERO);
+ throw 'oh no';
+ }, onPlatform: {
+ "vm": new Timeout(Duration.ZERO)
});
}
''').create();
@@ -509,7 +512,10 @@ import 'dart:async';
import 'package:test/test.dart';
void main() {
- test("fail", () => throw 'oh no');
+ test("fail", () async {
+ await new Future.delayed(Duration.ZERO);
+ throw 'oh no';
+ });
}
''').create();
« no previous file with comments | « test/runner/pause_after_load_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698