Re-enable the ANGLE dEQP tests on Linux on the GPU FYI waterfall

Re-enable the ANGLE dEQP tests on Linux on the GPU FYI waterfall

BUG=580045
TBR=dpranke@chromium.org
NOTRY=true

Committed: https://crrev.com/905db95f877347cf0fba0f5847e8069c5985d331
Cr-Commit-Position: refs/heads/master@{#373108}

[Corentin Wallez, 2016-02-01 20:03:50]

cwallez@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-02-01 20:06:28]

kbr@chromium.org changed reviewers:
+ dpranke@chromium.org

[Ken Russell (switch to Gerrit), 2016-02-01 20:06:28]

lgtm

+dpranke for mb_config.pyl OWNERS review.

[Ken Russell (switch to Gerrit), 2016-02-01 20:13:39]

Dirk, apologies, I am going to TBR this simple change to you so we can get this
in. Multiple people are touching the JSON files today.

[Ken Russell (switch to Gerrit), 2016-02-01 20:13:48]

Description was changed from

==========
Re-enable the ANGLE dEQP tests on Linux on the GPU FYI waterfall

BUG=580045
==========

to

==========
Re-enable the ANGLE dEQP tests on Linux on the GPU FYI waterfall

BUG=580045
TBR=dpranke@chromium.org
NOTRY=true
==========

[Ken Russell (switch to Gerrit), 2016-02-01 20:14:13]

The CQ bit was checked by kbr@chromium.org

[Corentin Wallez, 2016-02-01 20:14:53]

The CQ bit was unchecked by cwallez@chromium.org

[Dirk Pranke, 2016-02-01 20:25:21]

lgtm

[Ken Russell (switch to Gerrit), 2016-02-03 00:50:29]

LGTM again. CQ'ing.

https://codereview.chromium.org/1654183002/diff/100001/content/test/gpu/gener...
File content/test/gpu/generate_buildbot_json.py (right):

https://codereview.chromium.org/1654183002/diff/100001/content/test/gpu/gener...
content/test/gpu/generate_buildbot_json.py:376: 'os_types': ['win', 'linux'],
We can get rid of the os_types specifier now. It's redundant now that the
swarming_dimension_sets are being specified. Please do this cleanup in a
follow-on CL. Thanks.

https://codereview.chromium.org/1654183002/diff/100001/testing/buildbot/gn_is...
File testing/buildbot/gn_isolate_map.pyl (right):

https://codereview.chromium.org/1654183002/diff/100001/testing/buildbot/gn_is...
testing/buildbot/gn_isolate_map.pyl:42: "label":
"//third_party/angle/src/tests:angle_deqp_gles2_tests",
These targets are only defined conditionally. Will this present any problems on
bots where they are undefined?

[Ken Russell (switch to Gerrit), 2016-02-03 00:50:35]

The CQ bit was checked by kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-02-03 00:50:35]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1654183002/#ps100001
(title: "whitespace")

[Ken Russell (switch to Gerrit), 2016-02-03 00:50:55]

https://codereview.chromium.org/1654183002/diff/100001/testing/buildbot/gn_is...
File testing/buildbot/gn_isolate_map.pyl (right):

https://codereview.chromium.org/1654183002/diff/100001/testing/buildbot/gn_is...
testing/buildbot/gn_isolate_map.pyl:42: "label":
"//third_party/angle/src/tests:angle_deqp_gles2_tests",
On 2016/02/03 00:50:29, Ken Russell wrote:
> These targets are only defined conditionally. Will this present any problems
on
> bots where they are undefined?

To answer my own question, I guess we'll find out via the CQ.

[commit-bot: I haz the power, 2016-02-03 00:51:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1654183002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1654183002/100001

[commit-bot: I haz the power, 2016-02-03 00:59:19]

Description was changed from

==========
Re-enable the ANGLE dEQP tests on Linux on the GPU FYI waterfall

BUG=580045
TBR=dpranke@chromium.org
NOTRY=true
==========

to

==========
Re-enable the ANGLE dEQP tests on Linux on the GPU FYI waterfall

BUG=580045
TBR=dpranke@chromium.org
NOTRY=true
==========

[commit-bot: I haz the power, 2016-02-03 00:59:20]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-02-03 01:00:38]

Description was changed from

==========
Re-enable the ANGLE dEQP tests on Linux on the GPU FYI waterfall

BUG=580045
TBR=dpranke@chromium.org
NOTRY=true
==========

to

==========
Re-enable the ANGLE dEQP tests on Linux on the GPU FYI waterfall

BUG=580045
TBR=dpranke@chromium.org
NOTRY=true

Committed: https://crrev.com/905db95f877347cf0fba0f5847e8069c5985d331
Cr-Commit-Position: refs/heads/master@{#373108}
==========

[commit-bot: I haz the power, 2016-02-03 01:00:39]

Patchset 6 (id:??) landed as
https://crrev.com/905db95f877347cf0fba0f5847e8069c5985d331
Cr-Commit-Position: refs/heads/master@{#373108}

[Ken Russell (switch to Gerrit), 2016-02-03 07:24:26]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1664663002/ by kbr@chromium.org.

The reason for reverting is: Still failing compilation. See for example:

https://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Linux%20Builder/...

ninja -w dupbuild=err -C /b/build/slave/GPU_Linux_Builder/build/src/out/Release
angle_deqp_gles2_tests angle_deqp_gles2_tests_run angle_deqp_gles3_tests
angle_deqp_gles3_tests_run angle_end2end_tests angle_end2end_tests_run
angle_unittests angle_unittests_run audio_unittests audio_unittests_run
browser_tests content_gl_tests content_gl_tests_run gl_tests gl_tests_run
gl_unittests gl_unittests_run gles2_conform_test gles2_conform_test_run
tab_capture_end2end_tests_run telemetry_gpu_test_run -j50
ninja: Entering directory
`/b/build/slave/GPU_Linux_Builder/build/src/out/Release'
ninja: error: unknown target 'angle_deqp_gles2_tests_run'
.