Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 1654163003: [turbofan] Delay initialization in escape analysis (Closed)

Created:
4 years, 10 months ago by sigurds
Modified:
4 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Delay initialization in escape analysis This is also a refactoring of the merge function in escape analysis. BUG=v8:4586 LOG=n Committed: https://crrev.com/5aa72daa88dda209e69bbff83f6d8c9a585996fa Cr-Commit-Position: refs/heads/master@{#33728}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Small improvements #

Patch Set 3 : Refactor large function for better readability #

Patch Set 4 : Rebase #

Patch Set 5 : Simplify #

Total comments: 1

Patch Set 6 : Make --trace-turbo-escape a proper debug flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -105 lines) Patch
M src/compiler/escape-analysis.h View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/escape-analysis.cc View 1 2 3 4 5 16 chunks +98 lines, -102 lines 0 comments Download
M src/compiler/escape-analysis-reducer.cc View 1 2 3 4 3 chunks +8 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
sigurds
PTAL https://codereview.chromium.org/1654163003/diff/1/src/compiler/escape-analysis.cc File src/compiler/escape-analysis.cc (left): https://codereview.chromium.org/1654163003/diff/1/src/compiler/escape-analysis.cc#oldcode474 src/compiler/escape-analysis.cc:474: status_(graph->NodeCount(), kUnknown, zone), This initialization happens in EscapeAnalysis::Run() ...
4 years, 10 months ago (2016-02-02 11:37:14 UTC) #3
Michael Starzinger
LGTM. https://codereview.chromium.org/1654163003/diff/80001/src/compiler/escape-analysis.cc File src/compiler/escape-analysis.cc (right): https://codereview.chromium.org/1654163003/diff/80001/src/compiler/escape-analysis.cc#newcode772 src/compiler/escape-analysis.cc:772: if (FLAG_trace_turbo_escape) { nit: This can be achieve ...
4 years, 10 months ago (2016-02-04 10:10:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1654163003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1654163003/100001
4 years, 10 months ago (2016-02-04 11:22:41 UTC) #8
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 10 months ago (2016-02-04 11:24:13 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 11:24:43 UTC) #12
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/5aa72daa88dda209e69bbff83f6d8c9a585996fa
Cr-Commit-Position: refs/heads/master@{#33728}

Powered by Google App Engine
This is Rietveld 408576698