Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1383)

Issue 1654153002: Introduce a flag to force program abort on type/assertion errors. (Closed)

Created:
4 years, 10 months ago by Vyacheslav Egorov (Google)
Modified:
4 years, 10 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Introduce a flag to force program abort on type/assertion errors. We intend to switch this turn this flag on for dart2js buildbots to collect more information about impossible type-errors that sporadically occur there. R=iposva@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/6c85aca6d29425e0b84cf86eaa7e4528d749865c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M runtime/lib/errors.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/exceptions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/exceptions.cc View 4 chunks +18 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Vyacheslav Egorov (Google)
4 years, 10 months ago (2016-02-01 19:47:28 UTC) #1
Ivan Posva
LGTM -ip
4 years, 10 months ago (2016-02-02 00:25:11 UTC) #2
Vyacheslav Egorov (Google)
4 years, 10 months ago (2016-02-02 00:53:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6c85aca6d29425e0b84cf86eaa7e4528d749865c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698