Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2368)

Issue 1654143002: Add codereview.settings file. (Closed)

Created:
4 years, 10 months ago by viettrungluu
Modified:
4 years, 10 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/domokit/base@master
Target Ref:
refs/heads/master
Project:
mojo_base
Visibility:
Public.

Description

Add codereview.settings file. R=jamesr@chromium.org Committed: cc5014a66719d537673e2a8a34134f3197c44b42

Patch Set 1 #

Total comments: 3

Patch Set 2 : remove RUN_POST_UPLOAD_HOOK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
A codereview.settings View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
https://codereview.chromium.org/1654143002/diff/1/codereview.settings File codereview.settings (right): https://codereview.chromium.org/1654143002/diff/1/codereview.settings#newcode3 codereview.settings:3: PROJECT: mojo_base I just made up the mojo_base "project" ...
4 years, 10 months ago (2016-02-01 18:35:47 UTC) #1
jamesr
lgtm with the post upload line removed https://codereview.chromium.org/1654143002/diff/1/codereview.settings File codereview.settings (right): https://codereview.chromium.org/1654143002/diff/1/codereview.settings#newcode3 codereview.settings:3: PROJECT: mojo_base ...
4 years, 10 months ago (2016-02-01 18:38:34 UTC) #2
viettrungluu
4 years, 10 months ago (2016-02-01 18:41:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
cc5014a66719d537673e2a8a34134f3197c44b42 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698