Disable an extension when it is upgraded to a version that requires more

chrome/browser/extensions/extension_browsertest.cc

 #include "chrome/browser/extensions/extension_browsertest.h"
 
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "base/path_service.h"
 #include "chrome/browser/browser.h"
 #include "chrome/browser/browser_window.h"
 #include "chrome/browser/location_bar.h"
 #include "chrome/browser/extensions/extension_host.h"
 #include "chrome/browser/extensions/extensions_service.h"
@@ skipping 24 matching lines @@
 
   command_line->AppendSwitch(switches::kEnableExtensions);
 
   PathService::Get(chrome::DIR_TEST_DATA, &test_data_dir_);
   test_data_dir_ = test_data_dir_.AppendASCII("extensions");
 }
 
 bool ExtensionBrowserTest::LoadExtension(const FilePath& path) {
   ExtensionsService* service = browser()->profile()->GetExtensionsService();
   size_t num_before = service->extensions()->size();
-  registrar_.Add(this, NotificationType::EXTENSIONS_LOADED,
-                 NotificationService::AllSources());
-  service->LoadExtension(path);
-  MessageLoop::current()->PostDelayedTask(FROM_HERE, new MessageLoop::QuitTask,
-      kTimeoutMs);
-  ui_test_utils::RunMessageLoop();
-  registrar_.Remove(this, NotificationType::EXTENSIONS_LOADED,
-                    NotificationService::AllSources());
+  {
+    NotificationRegistrar registrar;
+    registrar.Add(this, NotificationType::EXTENSIONS_LOADED,
+                  NotificationService::AllSources());
+    service->LoadExtension(path);
+    MessageLoop::current()->PostDelayedTask(
+        FROM_HERE, new MessageLoop::QuitTask, kTimeoutMs);
+    ui_test_utils::RunMessageLoop();
+  }
   size_t num_after = service->extensions()->size();
   if (num_after != (num_before + 1))
     return false;
 
   return WaitForExtensionHostsToLoad();
 }
 
-bool ExtensionBrowserTest::InstallExtension(const FilePath& path) {
+bool ExtensionBrowserTest::InstallExtension(const FilePath& path,
+                                            int expected_change) {
   ExtensionsService* service = browser()->profile()->GetExtensionsService();
   service->set_show_extensions_prompts(false);
   size_t num_before = service->extensions()->size();
 
-  registrar_.Add(this, NotificationType::EXTENSIONS_LOADED,
-                 NotificationService::AllSources());
-  service->InstallExtension(path);
-  MessageLoop::current()->PostDelayedTask(FROM_HERE, new MessageLoop::QuitTask,
-      kTimeoutMs);
-  ui_test_utils::RunMessageLoop();
-  registrar_.Remove(this, NotificationType::EXTENSIONS_LOADED,
-                    NotificationService::AllSources());
+  {
+    NotificationRegistrar registrar;
+    registrar.Add(this, NotificationType::EXTENSIONS_LOADED,
+                  NotificationService::AllSources());
+    registrar.Add(this, NotificationType::EXTENSION_LOAD_DISABLED,
+                  NotificationService::AllSources());
+    service->InstallExtension(path);
+    MessageLoop::current()->PostDelayedTask(
+        FROM_HERE, new MessageLoop::QuitTask, kTimeoutMs);
+    ui_test_utils::RunMessageLoop();
+  }
+
   size_t num_after = service->extensions()->size();
-  if (num_after != (num_before + 1)) {
+  if (num_after != (num_before + expected_change)) {
     std::cout << "Num extensions before: " << IntToString(num_before) << " "
               << "num after: " << IntToString(num_after) << " "
               << "Installed extensions follow:\n";
 
     for (size_t i = 0; i < service->extensions()->size(); ++i)
       std::cout << "  " << service->extensions()->at(i)->id() << "\n";
 
     std::cout << "Errors follow:\n";
     const std::vector<std::string>* errors =
         ExtensionErrorReporter::GetInstance()->GetErrors();
@@ skipping 55 matching lines @@
       MessageLoop::current()->PostDelayedTask(FROM_HERE,
           new MessageLoop::QuitTask, 200);
       ui_test_utils::RunMessageLoop();
     }
   }
 
   return true;
 }
 
 void ExtensionBrowserTest::Observe(NotificationType type,
-                     const NotificationSource& source,
-                     const NotificationDetails& details) {
+                                   const NotificationSource& source,
+                                   const NotificationDetails& details) {
   switch (type.value) {
     case NotificationType::EXTENSIONS_LOADED:
       std::cout << "Got EXTENSION_LOADED notification.\n";
       MessageLoopForUI::current()->Quit();
       break;
 
+    case NotificationType::EXTENSION_LOAD_DISABLED:
+      std::cout << "Got EXTENSIONS_DISABLED_LOAD notification.\n";
+      MessageLoopForUI::current()->Quit();
+      break;
+
     default:
       NOTREACHED();
       break;
   }
 }