Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelection.h

Issue 1654123002: Invalidate the previous caret even if the parent text node is removed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: patch for land v2 Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/FrameSelection.h
diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.h b/third_party/WebKit/Source/core/editing/FrameSelection.h
index 7ae465cda55a0e2d1333347929d9ce3b57d216f6..3c822da0e04f3d578a330c077d5fc1352bb7f4cd 100644
--- a/third_party/WebKit/Source/core/editing/FrameSelection.h
+++ b/third_party/WebKit/Source/core/editing/FrameSelection.h
@@ -188,7 +188,6 @@ public:
void scheduleVisualUpdate() const;
void invalidateCaretRect();
void paintCaret(GraphicsContext&, const LayoutPoint&);
- bool ShouldPaintCaretForTesting() const { return m_shouldPaintCaret; }
// Used to suspend caret blinking while the mouse is down.
void setCaretBlinkingSuspended(bool suspended) { m_isCaretBlinkingSuspended = suspended; }
@@ -287,6 +286,10 @@ private:
GranularityStrategy* granularityStrategy();
+ // For unittests
+ bool shouldPaintCaretForTesting() const { return m_shouldPaintCaret; }
+ bool isPreviousCaretDirtyForTesting() const { return m_previousCaretNode; }
+
RawPtrWillBeMember<LocalFrame> m_frame;
const OwnPtrWillBeMember<PendingSelection> m_pendingSelection;
const OwnPtrWillBeMember<SelectionEditor> m_selectionEditor;
« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698