Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: third_party/WebKit/Source/core/editing/FrameSelection.h

Issue 1654123002: Invalidate the previous caret even if the parent text node is removed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more polishing if statement Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 282 matching lines...) Expand 10 before | Expand all | Expand 10 after
293 RawPtrWillBeMember<LocalFrame> m_frame; 293 RawPtrWillBeMember<LocalFrame> m_frame;
294 const OwnPtrWillBeMember<PendingSelection> m_pendingSelection; 294 const OwnPtrWillBeMember<PendingSelection> m_pendingSelection;
295 const OwnPtrWillBeMember<SelectionEditor> m_selectionEditor; 295 const OwnPtrWillBeMember<SelectionEditor> m_selectionEditor;
296 296
297 // Used to store base before the adjustment at bidi boundary 297 // Used to store base before the adjustment at bidi boundary
298 VisiblePosition m_originalBase; 298 VisiblePosition m_originalBase;
299 VisiblePositionInComposedTree m_originalBaseInComposedTree; 299 VisiblePositionInComposedTree m_originalBaseInComposedTree;
300 TextGranularity m_granularity; 300 TextGranularity m_granularity;
301 301
302 RefPtrWillBeMember<Node> m_previousCaretNode; // The last node which painted the caret. Retained for clearing the old caret when it moves. 302 RefPtrWillBeMember<Node> m_previousCaretNode; // The last node which painted the caret. Retained for clearing the old caret when it moves.
303 RawPtrWillBeWeakMember<Node> m_parentOfPreviousCaretNode;
303 LayoutRect m_previousCaretRect; 304 LayoutRect m_previousCaretRect;
304 CaretVisibility m_previousCaretVisibility; 305 CaretVisibility m_previousCaretVisibility;
305 306
306 RefPtrWillBeMember<EditingStyle> m_typingStyle; 307 RefPtrWillBeMember<EditingStyle> m_typingStyle;
307 308
308 Timer<FrameSelection> m_caretBlinkTimer; 309 Timer<FrameSelection> m_caretBlinkTimer;
309 310
310 bool m_caretRectDirty : 1; 311 bool m_caretRectDirty : 1;
311 bool m_shouldPaintCaret : 1; 312 bool m_shouldPaintCaret : 1;
312 bool m_isCaretBlinkingSuspended : 1; 313 bool m_isCaretBlinkingSuspended : 1;
(...skipping 20 matching lines...) Expand all
333 } 334 }
334 } // namespace blink 335 } // namespace blink
335 336
336 #ifndef NDEBUG 337 #ifndef NDEBUG
337 // Outside the WebCore namespace for ease of invocation from gdb. 338 // Outside the WebCore namespace for ease of invocation from gdb.
338 void showTree(const blink::FrameSelection&); 339 void showTree(const blink::FrameSelection&);
339 void showTree(const blink::FrameSelection*); 340 void showTree(const blink::FrameSelection*);
340 #endif 341 #endif
341 342
342 #endif // FrameSelection_h 343 #endif // FrameSelection_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698