Invalidate the previous caret even if the parent text node is removed.

third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/editing/FrameSelection.h"
 
 #include "bindings/core/v8/ExceptionStatePlaceholder.h"
 #include "core/dom/Document.h"
 #include "core/dom/Element.h"
 #include "core/dom/Text.h"
 #include "core/editing/EditingTestBase.h"
 #include "core/frame/FrameView.h"
 #include "core/html/HTMLBodyElement.h"
 #include "core/html/HTMLDocument.h"
 #include "core/layout/LayoutView.h"
 #include "core/paint/PaintInfo.h"
+#include "core/paint/PaintLayer.h"
 #include "core/testing/DummyPageHolder.h"
 #include "platform/graphics/paint/DrawingRecorder.h"
 #include "platform/graphics/paint/PaintController.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "wtf/OwnPtr.h"
 #include "wtf/PassRefPtr.h"
 #include "wtf/RefPtr.h"
 #include "wtf/StdLibExtras.h"
 
 namespace blink {
 
 class FrameSelectionTest : public EditingTestBase {
 protected:
     void setSelection(const VisibleSelection&);
     FrameSelection& selection() const;
     const VisibleSelection& visibleSelectionInDOMTree() const { return selection().selection(); }
     const VisibleSelectionInFlatTree& visibleSelectionInFlatTree() const { return selection().selectionInFlatTree(); }
 
     PassRefPtrWillBeRawPtr<Text> appendTextNode(const String& data);
     int layoutCount() const { return dummyPageHolder().frameView().layoutCount(); }
 
+    bool ShouldPaintCaretForTesting() const { return selection().ShouldPaintCaretForTesting(); }

[jbroman, 2016/02/25 18:29:22]

same here

+    bool isPreviousCaretDirtyForTesting() const { return selection().isPreviousCaretDirtyForTesting(); }
+
 private:
     RefPtrWillBePersistent<Text> m_textNode;
 };
 
 void FrameSelectionTest::setSelection(const VisibleSelection& newSelection)
 {
     dummyPageHolder().frame().selection().setSelection(newSelection);
 }
 
 FrameSelection& FrameSelectionTest::selection() const
@@ skipping 62 matching lines @@
     document().view()->updateAllLifecyclePhases();
 
     document().body()->setContentEditable("true", ASSERT_NO_EXCEPTION);
     document().body()->focus();
     EXPECT_TRUE(document().body()->focused());
 
     VisibleSelection validSelection(Position(text, 0), Position(text, 0));
     selection().setCaretVisible(true);
     setSelection(validSelection);
     EXPECT_TRUE(selection().isCaret());
-    EXPECT_TRUE(selection().ShouldPaintCaretForTesting());
+    EXPECT_TRUE(ShouldPaintCaretForTesting());
 
     int startCount = layoutCount();
     {
         // To force layout in next updateLayout calling, widen view.
         FrameView& frameView = dummyPageHolder().frameView();
         IntRect frameRect = frameView.frameRect();
         frameRect.setWidth(frameRect.width() + 1);
         frameRect.setHeight(frameRect.height() + 1);
         dummyPageHolder().frameView().setFrameRect(frameRect);
     }
     OwnPtr<PaintController> paintController = PaintController::create();
     GraphicsContext context(*paintController);
     DrawingRecorder drawingRecorder(context, *dummyPageHolder().frameView().layoutView(), DisplayItem::Caret, LayoutRect::infiniteIntRect());
     selection().paintCaret(context, LayoutPoint());
     EXPECT_EQ(startCount, layoutCount());
 }
 
+TEST_F(FrameSelectionTest, InvalidatePreviousCaretAfterRemovingLastCharacter)
+{
+    RefPtrWillBeRawPtr<Text> text = appendTextNode("Hello, World!");
+    document().view()->updateAllLifecyclePhases();
+
+    document().body()->setContentEditable("true", ASSERT_NO_EXCEPTION);
+    document().body()->focus();
+    EXPECT_TRUE(document().body()->focused());
+
+    selection().setCaretVisible(true);
+    EXPECT_TRUE(selection().isCaret());
+    EXPECT_TRUE(ShouldPaintCaretForTesting());
+
+    // Simulate to type "Hello, World!".
+    DisableCompositingQueryAsserts disabler;
+    selection().moveTo(createVisiblePosition(selection().end(), selection().affinity()), NotUserTriggered);
+    selection().setCaretRectNeedsUpdate();
+    EXPECT_TRUE(selection().isCaretBoundsDirty());
+    EXPECT_FALSE(isPreviousCaretDirtyForTesting());
+    selection().invalidateCaretRect();
+    EXPECT_FALSE(selection().isCaretBoundsDirty());
+    EXPECT_TRUE(isPreviousCaretDirtyForTesting());
+
+    // Simulate to remove all except for "H".
+    text->replaceWholeText("H");
+    selection().moveTo(createVisiblePosition(selection().end(), selection().affinity()), NotUserTriggered);
+    selection().setCaretRectNeedsUpdate();
+    EXPECT_TRUE(selection().isCaretBoundsDirty());
+    // "H" remains so early previousCaret invalidation isn't needed.
+    EXPECT_TRUE(isPreviousCaretDirtyForTesting());
+    selection().invalidateCaretRect();
+    EXPECT_FALSE(selection().isCaretBoundsDirty());
+    EXPECT_TRUE(isPreviousCaretDirtyForTesting());
+
+    // Simulate to remove the last character.
+    document().body()->removeChild(text);
+    // This line is the objective of this test.
+    // As removing the last character, early previousCaret invalidation is executed.
+    EXPECT_FALSE(isPreviousCaretDirtyForTesting());
+    document().updateLayoutIgnorePendingStylesheets();
+    selection().setCaretRectNeedsUpdate();
+    EXPECT_TRUE(selection().isCaretBoundsDirty());
+    EXPECT_FALSE(isPreviousCaretDirtyForTesting());
+    selection().invalidateCaretRect();
+    EXPECT_FALSE(selection().isCaretBoundsDirty());
+    EXPECT_TRUE(isPreviousCaretDirtyForTesting());
+}
+
 #define EXPECT_EQ_SELECTED_TEXT(text) \
     EXPECT_EQ(text, WebString(selection().selectedText()).utf8())
 
 TEST_F(FrameSelectionTest, SelectWordAroundPosition)
 {
     // "Foo Bar  Baz,"
     RefPtrWillBeRawPtr<Text> text = appendTextNode("Foo Bar&nbsp;&nbsp;Baz,");
     // "Fo|o Bar  Baz,"
     EXPECT_TRUE(selection().selectWordAroundPosition(createVisiblePosition(Position(text, 2))));
     EXPECT_EQ_SELECTED_TEXT("Foo");
@@ skipping 85 matching lines @@
 
 TEST_F(FrameSelectionTest, SelectAllWithUnselectableRoot)
 {
     RefPtrWillBeRawPtr<Element> select = document().createElement("select", ASSERT_NO_EXCEPTION);
     document().replaceChild(select.get(), document().documentElement());
     selection().selectAll();
     EXPECT_TRUE(selection().isNone()) << "Nothing should be selected if the content of the documentElement is not selctable.";
 }
 
 } // namespace blink