Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

Issue 1654063002: DevTools: Fix sorting by type in network panel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
index 194f85df499ba430db604b47b47978ab3a4dac45..e78b951269540a4b30ba738ef7fc7cf58eab8ed4 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
@@ -309,15 +309,7 @@ WebInspector.NetworkDataGridNode.prototype = {
*/
_renderTypeCell: function(cell)
{
- var mimeType = this._request.mimeType || this._request.requestContentType() || "";
- var resourceType = this._request.resourceType();
- var simpleType = resourceType.name();
-
- if (resourceType == WebInspector.resourceTypes.Other
- || resourceType == WebInspector.resourceTypes.Image)
- simpleType = mimeType.replace(/^(application|image)\//, "");
-
- cell.setTextAndTitle(simpleType);
+ cell.setTextAndTitle(this._request.displayType());
},
/**
@@ -602,6 +594,23 @@ WebInspector.NetworkDataGridNode.SizeComparator = function(a, b)
* @param {!WebInspector.NetworkDataGridNode} b
* @return {number}
*/
+WebInspector.NetworkDataGridNode.TypeComparator = function(a, b)
+{
+ var aSimpleType = a._request.displayType();
+ var bSimpleType = b._request.displayType();
+
+ if (aSimpleType > bSimpleType)
+ return 1;
+ if (bSimpleType > aSimpleType)
+ return -1;
+ return a._request.indentityCompare(b._request);
+}
+
+/**
+ * @param {!WebInspector.NetworkDataGridNode} a
+ * @param {!WebInspector.NetworkDataGridNode} b
+ * @return {number}
+ */
WebInspector.NetworkDataGridNode.InitiatorComparator = function(a, b)
{
var aInitiator = a._request.initiatorInfo();

Powered by Google App Engine
This is Rietveld 408576698