Fixes for bugs ##29090 "Downloads turns into zombies, if Incognito window is ...

Fixes for bugs ##29090 "Downloads turns into zombies, if Incognito window is opened" and 30419 "Renderer crash triggers Chrome Exit event in particular use case"
BUG=29090, 30419
TEST=Now the prompt will appear before last window of the type (incognito or not) is closed.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44985

[GeorgeY, 2010-04-15 00:19:52]

Prevents closing all regular windows if regular download is initiated and
incognito windows if incognito download is initiated.

[Jay Civelli, 2010-04-15 21:02:29]

http://codereview.chromium.org/1654011/diff/3001/4001
File chrome/browser/browser.cc (right):

http://codereview.chromium.org/1654011/diff/3001/4001#newcode3209
chrome/browser/browser.cc:3209: download_manager =
profile_->GetOriginalProfile()->GetDownloadManager();
Shouldn't that be in the previous block? I thought
GetOriginalProfile()->GetDownloadManager() would return the non incognito
download manager in incognito mode.

http://codereview.chromium.org/1654011/diff/3001/4001#newcode3213
chrome/browser/browser.cc:3213: (download_manager &&
download_manager->in_progress_count() != 0);
Nit: should be 4 space indented.

http://codereview.chromium.org/1654011/diff/3001/4001#newcode3220
chrome/browser/browser.cc:3220: // that are being closed.
Could you add to this comment what our new strategy is with regard to
incognito/non incognito windows, like explaing:
If this window is incognito/non-incognito and is the last one, what do we do?

[GeorgeY, 2010-04-16 19:56:36]

All done

http://codereview.chromium.org/1654011/diff/3001/4001
File chrome/browser/browser.cc (right):

http://codereview.chromium.org/1654011/diff/3001/4001#newcode3209
chrome/browser/browser.cc:3209: download_manager =
profile_->GetOriginalProfile()->GetDownloadManager();
On 2010/04/15 21:02:29, Jay Civelli wrote:
> Shouldn't that be in the previous block? I thought
> GetOriginalProfile()->GetDownloadManager() would return the non incognito
> download manager in incognito mode.
Good catch, but I am not sure if we can get into that state anyway :). Also
added comment.

http://codereview.chromium.org/1654011/diff/3001/4001#newcode3213
chrome/browser/browser.cc:3213: (download_manager &&
download_manager->in_progress_count() != 0);
On 2010/04/15 21:02:29, Jay Civelli wrote:
> Nit: should be 4 space indented.

Done.

http://codereview.chromium.org/1654011/diff/3001/4001#newcode3220
chrome/browser/browser.cc:3220: // that are being closed.
On 2010/04/15 21:02:29, Jay Civelli wrote:
> Could you add to this comment what our new strategy is with regard to
> incognito/non incognito windows, like explaing:
> If this window is incognito/non-incognito and is the last one, what do we do?

Done.

[Jay Civelli, 2010-04-16 20:29:57]

LGTM

http://codereview.chromium.org/1654011/diff/7001/8001
File chrome/browser/browser.cc (right):

http://codereview.chromium.org/1654011/diff/7001/8001#newcode3223
chrome/browser/browser.cc:3223: // 1. It is a regular browser and there no
regular downloads present or this
nit: wording "and there are no..."

http://codereview.chromium.org/1654011/diff/7001/8001#newcode3225
chrome/browser/browser.cc:3225: // 2. It is an incognito browser and there no
incognito downloads present or
nit: wording "and there are no..."

[GeorgeY, 2010-04-16 20:37:44]

done.
Will submit when tryservers pass.

http://codereview.chromium.org/1654011/diff/7001/8001
File chrome/browser/browser.cc (right):

http://codereview.chromium.org/1654011/diff/7001/8001#newcode3223
chrome/browser/browser.cc:3223: // 1. It is a regular browser and there no
regular downloads present or this
On 2010/04/16 20:29:57, Jay Civelli wrote:
> nit: wording "and there are no..."

Done.

http://codereview.chromium.org/1654011/diff/7001/8001#newcode3225
chrome/browser/browser.cc:3225: // 2. It is an incognito browser and there no
incognito downloads present or
On 2010/04/16 20:29:57, Jay Civelli wrote:
> nit: wording "and there are no..."

Done.