Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1653973003: [heap] Simplify distribution of remaining memory during sweeping & compaction (Closed)

Created:
4 years, 10 months ago by Michael Lippautz
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com, ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Simplify distribution of remaining memory during sweeping & compaction BUG=chromium:524425 LOG=N Committed: https://crrev.com/f72923526ccaa8faef5c977267b0c074c4a44dfa Cr-Commit-Position: refs/heads/master@{#33668}

Patch Set 1 : #

Patch Set 2 : Remove tests for dead code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -315 lines) Patch
M src/heap/mark-compact.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/heap/spaces.h View 3 chunks +0 lines, -11 lines 0 comments Download
M src/heap/spaces.cc View 2 chunks +0 lines, -47 lines 0 comments Download
M test/cctest/heap/heap-tester.h View 1 1 chunk +0 lines, -19 lines 0 comments Download
M test/cctest/heap/test-spaces.cc View 1 1 chunk +0 lines, -230 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
Michael Lippautz
PTAL. Just came across my own (dead) code while profiling... Dividing memory at this point ...
4 years, 10 months ago (2016-02-01 20:12:40 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1653973003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1653973003/60001
4 years, 10 months ago (2016-02-01 20:13:43 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_rel/builds/9618) v8_linux_mipsel_compile_rel on ...
4 years, 10 months ago (2016-02-01 20:17:33 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1653973003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1653973003/80001
4 years, 10 months ago (2016-02-02 08:17:06 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-02 08:41:55 UTC) #14
Hannes Payer (out of office)
On 2016/02/02 08:41:55, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 10 months ago (2016-02-02 09:17:36 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1653973003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1653973003/80001
4 years, 10 months ago (2016-02-02 10:36:13 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:80001)
4 years, 10 months ago (2016-02-02 10:38:58 UTC) #19
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f72923526ccaa8faef5c977267b0c074c4a44dfa Cr-Commit-Position: refs/heads/master@{#33668}
4 years, 10 months ago (2016-02-02 10:39:27 UTC) #21
Michael Hablich
4 years, 10 months ago (2016-02-03 08:49:13 UTC) #22
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:80001) has been created in
https://codereview.chromium.org/1661723003/ by hablich@chromium.org.

The reason for reverting is: Very likely blocking roll:
https://codereview.chromium.org/1652413003/.

Powered by Google App Engine
This is Rietveld 408576698