unroll srcover_1 for blending a single color

src/core/SkXfermode4f.cpp

 /*
  * Copyright 2016 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkPM4fPriv.h"
 #include "SkUtils.h"
 #include "SkXfermode.h"
@@ skipping 17 matching lines @@
 }
 
 template <DstType D> Sk4f load_dst(SkPMColor dstC) {
     return (D == kSRGB_Dst) ? Sk4f_fromS32(dstC) : Sk4f_fromL32(dstC);
 }
 
 template <DstType D> uint32_t store_dst(const Sk4f& x4) {
     return (D == kSRGB_Dst) ? Sk4f_toS32(x4) : Sk4f_toL32(x4);
 }
 
+static Sk4f linear_unit_to_srgb_255(const Sk4f& l4) {
+    return linear_to_srgb(l4) * Sk4f(255) + Sk4f(0.5f);
+}
+
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 
 static Sk4f scale_255_round(const SkPM4f& pm4) {
     return Sk4f::Load(pm4.fVec) * Sk4f(255) + Sk4f(0.5f);
 }
 
 static void pm4f_to_linear_32(SkPMColor dst[], const SkPM4f src[], int count) {
     while (count >= 4) {
         src[0].assertIsUnit();
         src[1].assertIsUnit();
@@ skipping 199 matching lines @@
     } else {
         for (int i = 0; i < count; ++i) {
             Sk4f s4 = Sk4f::Load(src[i].fVec);
             Sk4f d4 = load_dst<D>(dst[i]);
             Sk4f r4 = s4 + d4 * Sk4f(1 - get_alpha(s4));
             dst[i] = store_dst<D>(r4);
         }
     }
 }
 
 template <DstType D> void srcover_1(const SkXfermode::PM4fState& state, uint32_t dst[],

[mtklein, 2016/02/02 18:10:08]

At this point I think it'd be clearer to split srcover_1 apart into two explicit
specializations:

template <DstType D> 
void srcover_1(const SkXfermode::PM4fState& state, uint32_t dst[], const SkPM4f&
src, int count, const SkAlpha aa[]);

template <> 
void srcover_1<kLinear_Dst>(const SkXfermode::PM4fState& state, uint32_t dst[],
const SkPM4f& src, int count, const SkAlpha aa[]) {
   ...
}

template <> 
void srcover_1<kSRGB_Dst>(const SkXfermode::PM4fState& state, uint32_t dst[],
const SkPM4f& src, int count, const SkAlpha aa[]) {
   ...
}

[mtklein, 2016/02/02 18:10:46]

(otherwise lgtm)

                                     const SkPM4f& src, int count, const SkAlpha aa[]) {
     Sk4f s4 = Sk4f::Load(src.fVec);
-    Sk4f scale = Sk4f(1 - get_alpha(s4));
+    Sk4f dst_scale = Sk4f(1 - get_alpha(s4));
 
     if (aa) {
         for (int i = 0; i < count; ++i) {
             unsigned a = aa[i];
             if (0 == a) {
                 continue;
             }
             Sk4f d4 = load_dst<D>(dst[i]);
             Sk4f r4;
             if (a != 0xFF) {
                 s4 = scale_by_coverage(s4, a);
                 r4 = s4 + d4 * Sk4f(1 - get_alpha(s4));
             } else {
-                r4 = s4 + d4 * scale;
+                r4 = s4 + d4 * dst_scale;
             }
             dst[i] = store_dst<D>(r4);
         }
     } else {
-        for (int i = 0; i < count; ++i) {
-            Sk4f d4 = load_dst<D>(dst[i]);
-            Sk4f r4 = s4 + d4 * scale;
-            dst[i] = store_dst<D>(r4);
+        if (D == kLinear_Dst) {
+            // Do the blend math in 255-bias, since the dst bytes are already linear
+            s4 = s4 * Sk4f(255) + Sk4f(0.5f);   // +0.5 to pre-bias for rounding
+            while (count >= 4) {
+                Sk4f d0 = to_4f(dst[0]);
+                Sk4f d1 = to_4f(dst[1]);
+                Sk4f d2 = to_4f(dst[2]);
+                Sk4f d3 = to_4f(dst[3]);
+                Sk4f_ToBytes((uint8_t*)dst,
+                             s4 + d0 * dst_scale,
+                             s4 + d1 * dst_scale,
+                             s4 + d2 * dst_scale,
+                             s4 + d3 * dst_scale);
+                dst += 4;
+                count -= 4;
+            }
+            for (int i = 0; i < count; ++i) {
+                Sk4f d4 = to_4f(dst[i]);
+                dst[i] = to_4b(s4 + d4 * dst_scale);
+            }
+        } else {
+            // Do the blend math in unit-bias, since we have to convert to/from dst sRGB
+            while (count >= 4) {
+                Sk4f d0 = load_dst<D>(dst[0]);
+                Sk4f d1 = load_dst<D>(dst[1]);
+                Sk4f d2 = load_dst<D>(dst[2]);
+                Sk4f d3 = load_dst<D>(dst[3]);
+                Sk4f_ToBytes((uint8_t*)dst,
+                             linear_unit_to_srgb_255(s4 + d0 * dst_scale),
+                             linear_unit_to_srgb_255(s4 + d1 * dst_scale),
+                             linear_unit_to_srgb_255(s4 + d2 * dst_scale),
+                             linear_unit_to_srgb_255(s4 + d3 * dst_scale));
+                dst += 4;
+                count -= 4;
+            }
+            for (int i = 0; i < count; ++i) {
+                Sk4f d4 = load_dst<D>(dst[i]);
+                dst[i] = to_4b(linear_unit_to_srgb_255(s4 + d4 * dst_scale));
+            }
         }
     }
 }
 
 const XferProcPair gProcs_SrcOver[] = {
     { srcover_1<kLinear_Dst>,   srcover_n<kLinear_Dst> },   // linear   alpha
     { src_1<kLinear_Dst>,       src_n<kLinear_Dst>     },   // linear   opaque [ we are src-mode ]
     { srcover_1<kSRGB_Dst>,     srcover_n<kSRGB_Dst>   },   // srgb     alpha
     { src_1<kSRGB_Dst>,         src_n<kSRGB_Dst>       },   // srgb     opaque [ we are src-mode ]
 };
@@ skipping 25 matching lines @@
 
 SkXfermode::PM4fProc1 SkXfermode::getPM4fProc1(uint32_t flags) const {
     Mode mode;
     return this->asMode(&mode) ? GetPM4fProc1(mode, flags) : xfer_pm4_proc_1;
 }
 
 SkXfermode::PM4fProcN SkXfermode::getPM4fProcN(uint32_t flags) const {
     Mode mode;
     return this->asMode(&mode) ? GetPM4fProcN(mode, flags) : xfer_pm4_proc_n;
 }