Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 165393014: [Android] Always use pixels for gestures handled in ContentViewCore (Closed)

Created:
6 years, 10 months ago by jdduke (slow)
Modified:
6 years, 10 months ago
Reviewers:
boliu
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android] Always use pixels for gestures handled in ContentViewCore There were several cases where we were passing DIP coordinates for gestures being filtered and/or ack'ed in ContentViewCore. Fix this by re-scaling gesture-related coordinates to pixels before sending them to ContentViewCore. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252162

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M content/browser/android/content_view_core_impl.cc View 3 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jdduke (slow)
boliu@: Silly mistake =/ PTAL.
6 years, 10 months ago (2014-02-19 19:45:06 UTC) #1
boliu
Fixed slow fling in webview. lgtm stamp
6 years, 10 months ago (2014-02-19 19:51:37 UTC) #2
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 10 months ago (2014-02-19 20:21:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/165393014/1
6 years, 10 months ago (2014-02-19 20:25:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/165393014/1
6 years, 10 months ago (2014-02-20 00:22:11 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-20 02:28:38 UTC) #6
Message was sent while issue was closed.
Change committed as 252162

Powered by Google App Engine
This is Rietveld 408576698