Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 165393013: Resubmit 'Refactor the TrayAudio code so that it can be used by other platforms.' (Closed)

Created:
6 years, 10 months ago by zturner
Modified:
6 years, 10 months ago
Reviewers:
jennyz
CC:
chromium-reviews, kalyank, stevenjb+watch_chromium.org, sadrul, oshima+watch_chromium.org, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Resubmit 'Refactor the TrayAudio code so that it can be used by other platforms.' This resubmission fixes a memory leak that was causing ASAN bots to fail. Original code review: https://codereview.chromium.org/163953007 BUG=227247 R=jennyz@chromium.org TBR=jamescook, jennyz Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252064

Patch Set 1 #

Patch Set 2 : Rebase to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1241 lines, -752 lines) Patch
M ash/ash.gyp View 1 1 chunk +12 lines, -2 lines 0 comments Download
M ash/ash_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/ash_switches.cc View 1 chunk +5 lines, -1 line 0 comments Download
A ash/system/audio/audio_observer.h View 1 chunk +32 lines, -0 lines 0 comments Download
A + ash/system/audio/tray_audio.h View 2 chunks +25 lines, -20 lines 0 comments Download
A ash/system/audio/tray_audio.cc View 1 chunk +143 lines, -0 lines 0 comments Download
A ash/system/audio/tray_audio_delegate.h View 1 chunk +48 lines, -0 lines 0 comments Download
A ash/system/audio/volume_view.h View 1 chunk +90 lines, -0 lines 0 comments Download
A ash/system/audio/volume_view.cc View 1 chunk +332 lines, -0 lines 0 comments Download
A ash/system/chromeos/audio/audio_detailed_view.h View 1 chunk +66 lines, -0 lines 0 comments Download
A ash/system/chromeos/audio/audio_detailed_view.cc View 1 chunk +177 lines, -0 lines 0 comments Download
D ash/system/chromeos/audio/tray_audio.h View 1 chunk +0 lines, -61 lines 0 comments Download
D ash/system/chromeos/audio/tray_audio.cc View 1 chunk +0 lines, -663 lines 0 comments Download
A ash/system/chromeos/audio/tray_audio_chromeos.h View 1 chunk +42 lines, -0 lines 0 comments Download
A ash/system/chromeos/audio/tray_audio_chromeos.cc View 1 chunk +61 lines, -0 lines 0 comments Download
A ash/system/chromeos/audio/tray_audio_delegate_chromeos.h View 1 chunk +33 lines, -0 lines 0 comments Download
A ash/system/chromeos/audio/tray_audio_delegate_chromeos.cc View 1 chunk +65 lines, -0 lines 0 comments Download
M ash/system/tray/system_tray.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ash/system/tray/system_tray_notifier.h View 4 chunks +11 lines, -1 line 0 comments Download
M ash/system/tray/system_tray_notifier.cc View 2 chunks +43 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.h View 1 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 1 3 chunks +34 lines, -1 line 0 comments Download
M chromeos/audio/cras_audio_handler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chromeos/audio/cras_audio_handler.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jennyz
lgtm
6 years, 10 months ago (2014-02-19 19:02:19 UTC) #1
zturner
6 years, 10 months ago (2014-02-19 20:26:31 UTC) #2
Message was sent while issue was closed. 
Committed patchset #2 manually as r252064 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698