Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 165393009: Added "lang" attribute to the component updater update requests. (Closed)

Created:
6 years, 10 months ago by Sorin Jianu
Modified:
6 years, 10 months ago
CC:
chromium-reviews, waffles
Visibility:
Public.

Description

Added "lang" attribute to the component updater update requests. This is a change similar to https://codereview.chromium.org/153273002/ but for the component updater. BUG=336614 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251865

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M chrome/browser/component_updater/component_updater_utils.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/component_updater/test/component_updater_service_unittest.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Sorin Jianu
I will try the change soon, after r251403 clears lkgr.
6 years, 10 months ago (2014-02-14 22:55:07 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
6 years, 10 months ago (2014-02-14 23:55:25 UTC) #2
waffles
lgtm
6 years, 10 months ago (2014-02-18 17:15:44 UTC) #3
Sorin Jianu
The CQ bit was checked by sorin@chromium.org
6 years, 10 months ago (2014-02-18 20:04:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sorin@chromium.org/165393009/1
6 years, 10 months ago (2014-02-18 20:05:59 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 22:51:15 UTC) #6
Message was sent while issue was closed.
Change committed as 251865

Powered by Google App Engine
This is Rietveld 408576698