Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1401)

Unified Diff: content/common/gpu/client/gpu_channel_host.h

Issue 165393003: gpu: Generate mailboxes on client side (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/client/gpu_channel_host.h
diff --git a/content/common/gpu/client/gpu_channel_host.h b/content/common/gpu/client/gpu_channel_host.h
index ed83e015f45619c69a9ab16d89249d514522035e..2d98980ec6a9bd2bd4de9b7d0d14454b98e57bdf 100644
--- a/content/common/gpu/client/gpu_channel_host.h
+++ b/content/common/gpu/client/gpu_channel_host.h
@@ -38,10 +38,6 @@ class MessageLoop;
class MessageLoopProxy;
}
-namespace gpu {
-struct Mailbox;
-}
-
namespace IPC {
class SyncMessageFilter;
}
@@ -151,12 +147,6 @@ class GpuChannelHost : public IPC::Sender,
base::SharedMemoryHandle ShareToGpuProcess(
base::SharedMemoryHandle source_handle);
- // Generates |num| unique mailbox names that can be used with
- // GL_texture_mailbox_CHROMIUM. Unlike genMailboxCHROMIUM, this IPC is
- // handled only on the GPU process' IO thread, and so is not effectively
- // a finish.
- bool GenerateMailboxNames(unsigned num, std::vector<gpu::Mailbox>* names);
-
// Reserve one unused transfer buffer ID.
int32 ReserveTransferBufferId();
@@ -200,17 +190,8 @@ class GpuChannelHost : public IPC::Sender,
// Whether the channel is lost.
bool IsLost() const;
- // Gets mailboxes from the pool, and return the number of mailboxes to ask
- // the GPU process to maintain a good pool size. The caller is responsible
- // for sending the GpuChannelMsg_GenerateMailboxNamesAsync message.
- size_t GetMailboxNames(size_t num, std::vector<gpu::Mailbox>* names);
-
private:
virtual ~MessageFilter();
- bool OnControlMessageReceived(const IPC::Message& msg);
-
- // Message handlers.
- void OnGenerateMailboxNamesReply(const std::vector<gpu::Mailbox>& names);
// Threading notes: |listeners_| is only accessed on the IO thread. Every
// other field is protected by |lock_|.
@@ -222,12 +203,6 @@ class GpuChannelHost : public IPC::Sender,
// Whether the channel has been lost.
bool lost_;
-
- // A pool of valid mailbox names.
- std::vector<gpu::Mailbox> mailbox_name_pool_;
-
- // Number of pending mailbox requested from the GPU process.
- size_t requested_mailboxes_;
};
// Threading notes: all fields are constant during the lifetime of |this|

Powered by Google App Engine
This is Rietveld 408576698