Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 1653913002: X87: Change num_double_registers() to num_allocatable_double_registers() for TestStackSlot. (Closed)

Created:
4 years, 10 months ago by zhengxing.li
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Change num_double_registers() to num_allocatable_double_registers() for TestStackSlot. Although x87 has 8 registers, it use only 1 double register in TurboFan code generation for some limitations. So for TestStackSlot() function, use the num_allocatable_double_registers() to check the avaliable double registers of TurboFan is more suitable than num_double_registers(). BUG= Committed: https://crrev.com/a1a8dd141ee4071ec3f0cb9c71d76a4e606c1b44 Cr-Commit-Position: refs/heads/master@{#33636}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/cctest/compiler/test-run-native-calls.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
zhengxing.li
PTAL, thanks!
4 years, 10 months ago (2016-02-01 01:44:33 UTC) #2
ahaas
lgtm
4 years, 10 months ago (2016-02-01 07:53:25 UTC) #3
titzer
lgtm
4 years, 10 months ago (2016-02-01 08:02:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1653913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1653913002/1
4 years, 10 months ago (2016-02-01 08:03:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/13073)
4 years, 10 months ago (2016-02-01 08:25:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1653913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1653913002/1
4 years, 10 months ago (2016-02-01 08:33:26 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/13077)
4 years, 10 months ago (2016-02-01 08:47:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1653913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1653913002/1
4 years, 10 months ago (2016-02-01 10:42:09 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-01 10:53:59 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 10:54:40 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a1a8dd141ee4071ec3f0cb9c71d76a4e606c1b44
Cr-Commit-Position: refs/heads/master@{#33636}

Powered by Google App Engine
This is Rietveld 408576698