Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1567)

Unified Diff: ash/extended_desktop_unittest.cc

Issue 16539005: Skip mulitple-dispay tests on win8 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase again, and comment Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/extended_desktop_unittest.cc
diff --git a/ash/extended_desktop_unittest.cc b/ash/extended_desktop_unittest.cc
index 2a780f375bfd49d825dafce10a71514694d64e9a..f17716077ce05ed38ec21eea98647cb5c46ba168 100644
--- a/ash/extended_desktop_unittest.cc
+++ b/ash/extended_desktop_unittest.cc
@@ -157,6 +157,8 @@ class ExtendedDesktopTest : public test::AshTestBase {
// Test conditions that root windows in extended desktop mode
// must satisfy.
TEST_F(ExtendedDesktopTest, Basic) {
+ RETURN_IF_WIN8;
+
UpdateDisplay("1000x600,600x400");
Shell::RootWindowList root_windows = Shell::GetAllRootWindows();
@@ -176,6 +178,8 @@ TEST_F(ExtendedDesktopTest, Basic) {
}
TEST_F(ExtendedDesktopTest, Activation) {
+ RETURN_IF_WIN8;
+
UpdateDisplay("1000x600,600x400");
Shell::RootWindowList root_windows = Shell::GetAllRootWindows();
@@ -207,6 +211,8 @@ TEST_F(ExtendedDesktopTest, Activation) {
}
TEST_F(ExtendedDesktopTest, SystemModal) {
+ RETURN_IF_WIN8;
+
UpdateDisplay("1000x600,600x400");
Shell::RootWindowList root_windows = Shell::GetAllRootWindows();
@@ -242,6 +248,8 @@ TEST_F(ExtendedDesktopTest, SystemModal) {
}
TEST_F(ExtendedDesktopTest, TestCursor) {
+ RETURN_IF_WIN8;
+
UpdateDisplay("1000x600,600x400");
Shell::RootWindowList root_windows = Shell::GetAllRootWindows();
EXPECT_EQ(ui::kCursorPointer, root_windows[0]->last_cursor().native_type());
@@ -252,6 +260,8 @@ TEST_F(ExtendedDesktopTest, TestCursor) {
}
TEST_F(ExtendedDesktopTest, TestCursorLocation) {
+ RETURN_IF_WIN8;
+
UpdateDisplay("1000x600,600x400");
Shell::RootWindowList root_windows = Shell::GetAllRootWindows();
aura::test::WindowTestApi root_window0_test_api(root_windows[0]);
@@ -272,6 +282,8 @@ TEST_F(ExtendedDesktopTest, TestCursorLocation) {
}
TEST_F(ExtendedDesktopTest, CycleWindows) {
+ RETURN_IF_WIN8;
+
UpdateDisplay("700x500,500x500");
Shell::RootWindowList root_windows = Shell::GetAllRootWindows();
@@ -320,6 +332,8 @@ TEST_F(ExtendedDesktopTest, CycleWindows) {
}
TEST_F(ExtendedDesktopTest, GetRootWindowAt) {
+ RETURN_IF_WIN8;
+
UpdateDisplay("700x500,500x500");
SetSecondaryDisplayLayout(DisplayLayout::LEFT);
Shell::RootWindowList root_windows = Shell::GetAllRootWindows();
@@ -338,6 +352,8 @@ TEST_F(ExtendedDesktopTest, GetRootWindowAt) {
}
TEST_F(ExtendedDesktopTest, GetRootWindowMatching) {
+ RETURN_IF_WIN8;
+
UpdateDisplay("700x500,500x500");
SetSecondaryDisplayLayout(DisplayLayout::LEFT);
@@ -375,6 +391,8 @@ TEST_F(ExtendedDesktopTest, GetRootWindowMatching) {
}
TEST_F(ExtendedDesktopTest, Capture) {
+ RETURN_IF_WIN8;
+
UpdateDisplay("1000x600,600x400");
Shell::RootWindowList root_windows = Shell::GetAllRootWindows();
@@ -431,6 +449,8 @@ TEST_F(ExtendedDesktopTest, Capture) {
}
TEST_F(ExtendedDesktopTest, MoveWindow) {
+ RETURN_IF_WIN8;
+
UpdateDisplay("1000x600,600x400");
Shell::RootWindowList root_windows = Shell::GetAllRootWindows();
views::Widget* d1 = CreateTestWidget(gfx::Rect(10, 10, 100, 100));
@@ -465,6 +485,8 @@ TEST_F(ExtendedDesktopTest, MoveWindow) {
// Verifies if the mouse event arrives to the window even when the window
// moves to another root in a pre-target handler. See: crbug.com/157583
TEST_F(ExtendedDesktopTest, MoveWindowByMouseClick) {
+ RETURN_IF_WIN8;
+
UpdateDisplay("1000x600,600x400");
Shell::RootWindowList root_windows = Shell::GetAllRootWindows();
@@ -485,6 +507,8 @@ TEST_F(ExtendedDesktopTest, MoveWindowByMouseClick) {
}
TEST_F(ExtendedDesktopTest, MoveWindowToDisplay) {
+ RETURN_IF_WIN8;
+
UpdateDisplay("1000x1000,1000x1000");
Shell::RootWindowList root_windows = Shell::GetAllRootWindows();
@@ -514,6 +538,8 @@ TEST_F(ExtendedDesktopTest, MoveWindowToDisplay) {
}
TEST_F(ExtendedDesktopTest, MoveWindowWithTransient) {
+ RETURN_IF_WIN8;
+
UpdateDisplay("1000x600,600x400");
Shell::RootWindowList root_windows = Shell::GetAllRootWindows();
views::Widget* w1 = CreateTestWidget(gfx::Rect(10, 10, 100, 100));
@@ -572,6 +598,8 @@ namespace internal {
// Test if the Window::ConvertPointToTarget works across root windows.
// TODO(oshima): Move multiple display suport and this test to aura.
TEST_F(ExtendedDesktopTest, ConvertPoint) {
+ RETURN_IF_WIN8;
+
UpdateDisplay("1000x600,600x400");
Shell::RootWindowList root_windows = Shell::GetAllRootWindows();
gfx::Display& display_1 =
@@ -628,6 +656,8 @@ TEST_F(ExtendedDesktopTest, ConvertPoint) {
}
TEST_F(ExtendedDesktopTest, OpenSystemTray) {
+ RETURN_IF_WIN8;
+
UpdateDisplay("500x600,600x400");
SystemTray* tray = ash::Shell::GetInstance()->GetPrimarySystemTray();
ASSERT_FALSE(tray->HasSystemBubble());
@@ -659,6 +689,8 @@ TEST_F(ExtendedDesktopTest, OpenSystemTray) {
}
TEST_F(ExtendedDesktopTest, StayInSameRootWindow) {
+ RETURN_IF_WIN8;
+
UpdateDisplay("100x100,200x200");
Shell::RootWindowList root_windows = Shell::GetAllRootWindows();
views::Widget* w1 = CreateTestWidget(gfx::Rect(10, 10, 50, 50));
@@ -679,6 +711,8 @@ TEST_F(ExtendedDesktopTest, StayInSameRootWindow) {
}
TEST_F(ExtendedDesktopTest, KeyEventsOnLockScreen) {
+ RETURN_IF_WIN8;
+
UpdateDisplay("100x100,200x200");
Shell::RootWindowList root_windows = Shell::GetAllRootWindows();
@@ -749,6 +783,8 @@ TEST_F(ExtendedDesktopTest, KeyEventsOnLockScreen) {
}
TEST_F(ExtendedDesktopTest, PassiveGrab) {
+ RETURN_IF_WIN8;
+
EventLocationRecordingEventHandler event_handler;
ash::Shell::GetInstance()->AddPreTargetHandler(&event_handler);

Powered by Google App Engine
This is Rietveld 408576698