Issue 165387: Fix several bugs in First Run.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 165387: Fix several bugs in First Run. (Closed)

Created:
11 years, 4 months ago by jeremy

Modified:
9 years, 6 months ago

Reviewers:
stuartmorgan

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix several bugs in First Run. Chromium: * First run no longer displays every time you launch Chromium. * Enable Stats checkbox hidden (it doesn't do anything anyway in Chromium). General: * Import popup menu disables with checkbox. BUG=19163, 19171 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23188

Patch Set 1 #

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+80 lines, -5 lines)			Patch
M	chrome/app/nibs/FirstRunDialog.xib	View	3 chunks	+67 lines, -3 lines	0 comments	Download
M	chrome/browser/cocoa/first_run_dialog.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/cocoa/first_run_dialog.mm	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/first_run_mac.mm	View	2 chunks	+6 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

stuartmorgan

11 years, 4 months ago (2009-08-12 17:49:46 UTC) #2

LGTM

http://codereview.chromium.org/165387/diff/1/5
File chrome/browser/first_run_mac.mm (right):

http://codereview.chromium.org/165387/diff/1/5#newcode135
Line 135: #else
Seems like this would make more sense right after the other declaration of
stats_enabled; cutting out the |if| doesn't really buy us anything.

Expand Messages | Collapse Messages