Fix crash with new FTP in Incognito mode.

Fix crash with new FTP in Incognito mode.

TEST=See bug.
http://crbug.com/18697

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23190

[wtc, 2009-08-12 17:25:50]

LGTM.

Note: Since you're already working on this code, after
you check in this CL, could you write a new CL to switch
to new FTP by default?  That should be a separate CL because
we need to merge this CL into 3.0.

http://codereview.chromium.org/165386/diff/1/2
File chrome/browser/net/chrome_url_request_context.cc (right):

http://codereview.chromium.org/165386/diff/1/2#newcode210
Line 210: // The kNewFtp switch is Windows specific only because we have
multiple FTP
Nit: pick one of "specific" and "only".  We don't need both.

Hmm... I wonder if I wrote this comment :-)

Have you thought about whether the OTR URL request context
can just use the FTP transaction factory of the original
profile?  It seems that would be problematic when we start
to cache FTP directory listings.

http://codereview.chromium.org/165386/diff/1/2#newcode277
Line 277: context->http_transaction_factory_ = cache;
I wonder if we should set ftp_transaction_factory_ for
other kinds of ChromeURLRequestContext, for example, here.