Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1653833002: Add shared tests demonstrating bugs #25624, #25625, and #25626. (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add shared tests demonstrating bugs #25624, #25625, and #25626. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/4896fea5f5c22696159d44980413cfe16d23d446

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -8 lines) Patch
A + tests/language/accessor_conflict_export2_helper.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A tests/language/accessor_conflict_export2_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download
A + tests/language/accessor_conflict_export_helper.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A tests/language/accessor_conflict_export_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download
A + tests/language/accessor_conflict_getter.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A tests/language/accessor_conflict_import2_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download
A tests/language/accessor_conflict_import_prefixed2_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download
A tests/language/accessor_conflict_import_prefixed_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download
A tests/language/accessor_conflict_import_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download
A + tests/language/accessor_conflict_setter.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/language.status View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +7 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 10 months ago (2016-01-31 14:33:46 UTC) #2
Brian Wilkerson
LGTM
4 years, 10 months ago (2016-02-01 15:06:51 UTC) #3
Paul Berry
4 years, 10 months ago (2016-02-01 16:14:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4896fea5f5c22696159d44980413cfe16d23d446 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698