Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 165381: Merge 22369 - Fix plugin IPC issues.... (Closed)

Created:
11 years, 4 months ago by Mark Larson
Modified:
9 years, 7 months ago
Reviewers:
ananta
CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, jam
Visibility:
Public.

Description

Merge 22369 - Fix plugin IPC issues. The reliability tests regressions caused by this patch have been addressed by the upstream bug fix https://bugs.webkit.org/show_bug.cgi?id=27769 The IPCs for carrying data requested by plugins have been changed from synchronous IPCs to asynchronous IPCs. This fixes bug http://code.google.com/p/chromium/issues/detail?id=14323, where the Flash plugin would not render content on the page if these IPCs were processed while the plugin waited for sync calls like NPN_Evaluate to return. This CL also fixes the following bugs, which were crashes in reliability test runs when this patch was landed last time. http://code.google.com/p/chromium/issues/detail?id=18058 http://code.google.com/p/chromium/issues/detail?id=18059 The crash happens because of NPP_Write calls issued to the plugin while it is waiting for an NPN_Invoke call to return in the context of NPP_NewStream. Inspecting the safari plugin implementation revealed that they defer the resource load before calling the plugin and restore it on return. We emulate this behavior via an IPC sent from the plugin which serves as an acknowledgement. Test=covered by UI tests. Bug=14323, 18058, 18059 Review URL: http://codereview.chromium.org/159746 TBR=ananta@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23178

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -59 lines) Patch
MM chrome/common/plugin_messages_internal.h View 2 chunks +14 lines, -11 lines 0 comments Download
MM chrome/plugin/webplugin_delegate_stub.h View 1 chunk +1 line, -2 lines 0 comments Download
MM chrome/plugin/webplugin_delegate_stub.cc View 2 chunks +2 lines, -4 lines 0 comments Download
MM chrome/plugin/webplugin_proxy.h View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/plugin/webplugin_proxy.cc View 2 chunks +7 lines, -1 line 0 comments Download
MM chrome/renderer/webplugin_delegate_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
MM chrome/renderer/webplugin_delegate_proxy.cc View 4 chunks +9 lines, -4 lines 0 comments Download
MM webkit/glue/plugins/plugin_instance.cc View 1 chunk +1 line, -3 lines 0 comments Download
MM webkit/glue/plugins/plugin_stream_url.h View 1 chunk +1 line, -2 lines 0 comments Download
MM webkit/glue/plugins/plugin_stream_url.cc View 2 chunks +9 lines, -4 lines 0 comments Download
MM webkit/glue/plugins/test/plugin_get_javascript_url_test.h View 1 chunk +10 lines, -0 lines 0 comments Download
MM webkit/glue/plugins/test/plugin_get_javascript_url_test.cc View 6 chunks +82 lines, -1 line 0 comments Download
MM webkit/glue/webplugin.h View 2 chunks +5 lines, -2 lines 0 comments Download
MM webkit/glue/webplugin_impl.h View 4 chunks +7 lines, -3 lines 0 comments Download
MM webkit/glue/webplugin_impl.cc View 7 chunks +51 lines, -22 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Larson
11 years, 4 months ago (2009-08-12 07:03:35 UTC) #1
ananta
11 years, 4 months ago (2009-08-12 14:21:22 UTC) #2
LGTM. Please merge r22431 as well.

Powered by Google App Engine
This is Rietveld 408576698