Issue 1653733002: Support for embedder dependency changes (#25606).

Issue 1653733002: Support for embedder dependency changes (#25606). (Closed)

Created:
4 years, 10 months ago by pquitslund

Modified:
4 years, 10 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Support for embedder dependency changes (#25606). Adds logic to detect when a library embedder is added as a dependency and reconfigures the `SourceFactory` appropriately. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/fa08150ca67bbf7088f8985429a632139042b398

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+253 lines, -151 lines)			Patch
M	pkg/analysis_server/lib/src/context_manager.dart	View	1 2	2 chunks	+50 lines, -6 lines	0 comments	Download
M	pkg/analysis_server/test/context_manager_test.dart	View	1	1 chunk	+53 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/source/embedder.dart	View		3 chunks	+150 lines, -145 lines	0 comments	Download

Total messages: 7 (4 generated)

pquitslund

4 years, 10 months ago (2016-02-09 17:40:09 UTC) #7

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
fa08150ca67bbf7088f8985429a632139042b398 (presubmit successful).