content/renderer/webcrypto/platform_crypto.h - Issue 165373008: [webcrypto] Reject AES-GCM tag lengths other than 32, 64, 96, 104, 112, 120, 128.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/webcrypto/platform_crypto.h

Issue 165373008: [webcrypto] Reject AES-GCM tag lengths other than 32, 64, 96, 104, 112, 120, 128. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/webcrypto/platform_crypto.h

diff --git a/content/renderer/webcrypto/platform_crypto.h b/content/renderer/webcrypto/platform_crypto.h

index 6cb100a11bac8a3292d14a1e6c8bbf4658508539..0dd575fd8cfc029e9bd7a4a453ec737605ca662d 100644

--- a/content/renderer/webcrypto/platform_crypto.h

+++ b/content/renderer/webcrypto/platform_crypto.h

@@ -55,7 +55,7 @@ Status EncryptDecryptAesCbc(EncryptOrDecrypt mode,

// Preconditions:

// * |key| is a non-null AES-GCM key.

-// * |tag_length_bits| is in the range [0, 128].

+// * |tag_length_bits| is one of {32, 64, 96, 104, 112, 120, 128}

Status EncryptDecryptAesGcm(EncryptOrDecrypt mode,

SymKey* key,

const CryptoData& data,

« no previous file with comments | « no previous file | content/renderer/webcrypto/platform_crypto_nss.cc » ('j') | content/renderer/webcrypto/shared_crypto_unittest.cc » ('J')