Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 165373008: [webcrypto] Reject AES-GCM tag lengths other than 32, 64, 96, 104, 112, 120, 128. (Closed)

Created:
6 years, 10 months ago by eroman
Modified:
6 years, 10 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

[webcrypto] Reject AES-GCM tag lengths other than 32, 64, 96, 104, 112, 120, 128 bits. This matches the spec update https://dvcs.w3.org/hg/webcrypto-api/rev/1ed0fb7da636. (Before it was possible to use a tag length of 0 and have it succeed) BUG=245025 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252769

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -13 lines) Patch
M content/renderer/webcrypto/platform_crypto.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/webcrypto/platform_crypto_nss.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/webcrypto/shared_crypto.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/renderer/webcrypto/shared_crypto_unittest.cc View 1 chunk +1 line, -1 line 1 comment Download
M content/renderer/webcrypto/webcrypto_util.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/webcrypto/webcrypto_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
eroman
https://codereview.chromium.org/165373008/diff/1/content/renderer/webcrypto/shared_crypto_unittest.cc File content/renderer/webcrypto/shared_crypto_unittest.cc (right): https://codereview.chromium.org/165373008/diff/1/content/renderer/webcrypto/shared_crypto_unittest.cc#newcode1999 content/renderer/webcrypto/shared_crypto_unittest.cc:1999: uint8 kAlternateTagLengths[] = {0, 8, 96, 120, 128, 160, ...
6 years, 10 months ago (2014-02-20 01:28:21 UTC) #1
Ryan Sleevi
lgtm
6 years, 10 months ago (2014-02-21 22:22:37 UTC) #2
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 10 months ago (2014-02-21 22:26:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/165373008/1
6 years, 10 months ago (2014-02-21 22:26:50 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 23:36:59 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=268157
6 years, 10 months ago (2014-02-21 23:37:00 UTC) #6
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 10 months ago (2014-02-21 23:44:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/165373008/1
6 years, 10 months ago (2014-02-21 23:44:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/165373008/1
6 years, 10 months ago (2014-02-22 01:27:20 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-22 08:07:17 UTC) #10
Message was sent while issue was closed. 
Change committed as 252769

Powered by Google App Engine
This is Rietveld 408576698