Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 165373006: [safe browsing] Push missing download BINHASH histograms. (Closed)

Created:
6 years, 10 months ago by Scott Hess - ex-Googler
Modified:
6 years, 10 months ago
Reviewers:
Ilya Sherman, mattm
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org
Visibility:
Public.

Description

[safe browsing] Push missing download BINHASH histograms. To double-check that they haven't been firing. BUG=108130 R=mattm@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252262

Patch Set 1 #

Total comments: 1

Patch Set 2 : obsolete things #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Scott Hess - ex-Googler
The histograms are being deleted by: https://codereview.chromium.org/172393005/ For some reason, I thought I had managed ...
6 years, 10 months ago (2014-02-20 00:24:32 UTC) #1
mattm
lgtm
6 years, 10 months ago (2014-02-20 00:27:15 UTC) #2
Ilya Sherman
LGTM % nit. In general, it's strongly recommended to add histogram names to histograms.xml rather ...
6 years, 10 months ago (2014-02-20 00:31:13 UTC) #3
Scott Hess - ex-Googler
The CQ bit was checked by shess@chromium.org
6 years, 10 months ago (2014-02-20 01:02:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/165373006/60001
6 years, 10 months ago (2014-02-20 01:45:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/165373006/60001
6 years, 10 months ago (2014-02-20 05:15:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/165373006/60001
6 years, 10 months ago (2014-02-20 09:12:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/165373006/60001
6 years, 10 months ago (2014-02-20 12:32:21 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-20 16:22:03 UTC) #9
Message was sent while issue was closed.
Change committed as 252262

Powered by Google App Engine
This is Rietveld 408576698