Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 165372: Merge 22980 - Mask the close button on the download shelf so that it's visibl... (Closed)

Created:
11 years, 4 months ago by laforge
Modified:
9 years, 7 months ago
Reviewers:
Miranda Callahan
CC:
chromium-reviews_googlegroups.com, Paul Godavari, Ben Goodger (Google)
Visibility:
Public.

Description

Merge 22980 - Mask the close button on the download shelf so that it's visible even in dark themes. BUG= http://crbug.com/18451 TEST= Install a dark theme, cause download shelf to appear, note that the close button is visible. Review URL: http://codereview.chromium.org/164276 TBR=mirandac@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23159

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
MM chrome/app/theme/theme_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
MM chrome/browser/views/download_shelf_view.h View 1 chunk +6 lines, -0 lines 0 comments Download
MM chrome/browser/views/download_shelf_view.cc View 3 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
laforge
11 years, 4 months ago (2009-08-12 03:28:43 UTC) #1
Miranda Callahan
11 years, 4 months ago (2009-08-12 15:40:50 UTC) #2
LGTM

On 2009/08/12 03:28:43, laforge wrote:
>

Powered by Google App Engine
This is Rietveld 408576698