Issue 165372: Merge 22980 - Mask the close button on the download shelf so that it's visibl...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 165372: Merge 22980 - Mask the close button on the download shelf so that it's visibl... (Closed)

Created:
11 years, 4 months ago by laforge

Modified:
9 years, 7 months ago

Reviewers:
Miranda Callahan

CC:
chromium-reviews_googlegroups.com, Paul Godavari, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/branches/195/src/

Visibility:
Public.

Merge 22980 - Mask the close button on the download shelf so that it's visible even in dark themes. BUG= http://crbug.com/18451 TEST= Install a dark theme, cause download shelf to appear, note that the close button is visible. Review URL: http://codereview.chromium.org/164276 TBR=mirandac@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23159

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -1 line)			Patch
MM	chrome/app/theme/theme_resources.grd	View	1 chunk	+1 line, -0 lines	0 comments	Download
MM	chrome/browser/views/download_shelf_view.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
MM	chrome/browser/views/download_shelf_view.cc	View	3 chunks	+17 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

LGTM

On 2009/08/12 03:28:43, laforge wrote:
>