Runtime logging

src/codegen-ia32.cc

Index: src/codegen-ia32.cc
diff --git a/src/codegen-ia32.cc b/src/codegen-ia32.cc
index db269a0e32fd5dcef414fa06e463bdf06dc5bb1e..17e4a8d74125633df755e401c3c9f85bfe5bed0e 100644
--- a/src/codegen-ia32.cc
+++ b/src/codegen-ia32.cc
@@ -2900,6 +2900,25 @@ void CodeGenerator::GenerateIsSmi(ZoneList<Expression*>* args) {
 }
 
 
+void CodeGenerator::GenerateLog(ZoneList<Expression*>* args) {
+  // Conditionally generate a log call.

[Mads Ager (chromium), 2009/01/06 13:08:43]

Could you add this comment to the ARM code as well or add it in the header file?

[Christian Plesner Hansen, 2009/01/06 13:23:56]

I've added a comment in the arm version that says to see this comment -- I don't
want to duplicate the whole thing.  Note that there is no common header file.

+  // Args:
+  //   0 (literal string): The type of logging (corresponds to the flags).
+  //     This is used to determine whether or not to generate the log call.
+  //   1 (string): Format string.  Access the string at argument index 2
+  //     with '%2s' (see Logger::LogRuntime for all the formats).
+  //   2 (array): Arguments to the format string.
+  ASSERT_EQ(args->length(), 3);
+  if (ShouldGenerateLog(args->at(0))) {
+    Load(args->at(1));
+    Load(args->at(2));
+    __ CallRuntime(Runtime::kLog, 2);
+  }
+  // Finally, we're expected to leave a value on the top of the stack.
+  frame_->Push(Immediate(Factory::undefined_value()));
+}
+
+
 void CodeGenerator::GenerateIsNonNegativeSmi(ZoneList<Expression*>* args) {
   ASSERT(args->length() == 1);
   Load(args->at(0));