Issue 16537: Runtime logging

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16537: Runtime logging (Closed)

Created:
11 years, 11 months ago by Christian Plesner Hansen

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Added runtime call to the logging infrastructure. Made some changes to the way regexps are being logged.

Patch Set 1 #

Total comments: 2

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+134 lines, -30 lines)			Patch
M	src/codegen.cc	View	2 chunks	+16 lines, -1 line	0 comments	Download
M	src/codegen-arm.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/codegen-arm.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/codegen-ia32.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/codegen-ia32.cc	View	1 chunk	+19 lines, -0 lines	2 comments	Download
M	src/jsregexp.cc	View	5 chunks	+0 lines, -6 lines	0 comments	Download
M	src/log.h	View	3 chunks	+10 lines, -5 lines	0 comments	Download
M	src/log.cc	View	3 chunks	+45 lines, -16 lines	0 comments	Download
M	src/regexp-delay.js	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/runtime.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/runtime.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/string.js	View	3 chunks	+9 lines, -1 line	0 comments	Download
M	test/mjsunit/fuzz-natives.js	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/16537/diff/1/4 File src/codegen-ia32.cc (right): http://codereview.chromium.org/16537/diff/1/4#newcode2904 Line 2904: // Conditionally generate a log call. Could ...

11 years, 11 months ago (2009-01-06 13:08:43 UTC) #2

Christian Plesner Hansen

11 years, 11 months ago (2009-01-06 13:23:56 UTC) #3

http://codereview.chromium.org/16537/diff/1/4
File src/codegen-ia32.cc (right):

http://codereview.chromium.org/16537/diff/1/4#newcode2904
Line 2904: // Conditionally generate a log call.
I've added a comment in the arm version that says to see this comment -- I don't
want to duplicate the whole thing.  Note that there is no common header file.

Expand Messages | Collapse Messages