third_party/WebKit/Source/core/layout/LayoutTableSection.cpp - Issue 1653673002: Even more explicit LayoutUnit conversion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

Issue 1653673002: Even more explicit LayoutUnit conversion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@moarConstructors

Patch Set: address comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp b/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

index bdb5e1a47b3f6ee2ea25d9867e052bc7588f25fa..e1d97a4cf75fab47e601583ce75081a154494137 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

@@ -726,7 +726,7 @@ int LayoutTableSection::calcRowLogicalHeight()

for (unsigned r = 0; r < m_grid.size(); r++) {

m_grid[r].baseline = -1;

- LayoutUnit baselineDescent = 0;

+ LayoutUnit baselineDescent;

if (m_grid[r].logicalHeight.isSpecified()) {

// Our base size is the biggest logical height from our cells' styles (excluding row spanning cells).