third_party/WebKit/Source/core/layout/LayoutRubyRun.cpp - Issue 1653673002: Even more explicit LayoutUnit conversion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutRubyRun.cpp

Issue 1653673002: Even more explicit LayoutUnit conversion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@moarConstructors

Patch Set: address comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutRubyRun.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutRubyRun.cpp b/third_party/WebKit/Source/core/layout/LayoutRubyRun.cpp

index 85d695725bbf7c150675874c360a24a5066b8088..6ffc9f2572868b413713bc825e3b458a1a21a287 100644

--- a/third_party/WebKit/Source/core/layout/LayoutRubyRun.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutRubyRun.cpp

@@ -228,7 +228,7 @@ void LayoutRubyRun::layout()

// Place the LayoutRubyText such that its bottom is flush with the lineTop of the first line of the LayoutRubyBase.

LayoutUnit lastLineRubyTextBottom = rt->logicalHeight();

- LayoutUnit firstLineRubyTextTop = 0;

+ LayoutUnit firstLineRubyTextTop;

RootInlineBox* rootBox = rt->lastRootBox();

if (rootBox) {

// In order to align, we have to ignore negative leading.

@@ -237,7 +237,7 @@ void LayoutRubyRun::layout()

}

if (style()->isFlippedLinesWritingMode() == (style()->rubyPosition() == RubyPositionAfter)) {

- LayoutUnit firstLineTop = 0;

+ LayoutUnit firstLineTop;

if (LayoutRubyBase* rb = rubyBase()) {

RootInlineBox* rootBox = rb->firstRootBox();

if (rootBox)