Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 1653673002: Even more explicit LayoutUnit conversion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@moarConstructors
Patch Set: address comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index 1d70edb8fc544930f729e9b2e08928a058530083..e66941752fb87c3f9fc358e72a487e07dfa68d58 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -1002,7 +1002,7 @@ void FrameView::layout()
LayoutSize oldSize = m_size;
- m_size = LayoutSize(layoutSize().width(), layoutSize().height());
+ m_size = LayoutSize(layoutSize());
if (oldSize != m_size && !m_firstLayout) {
LayoutBox* rootLayoutObject = document->documentElement() ? document->documentElement()->layoutBox() : 0;
@@ -1416,7 +1416,7 @@ void FrameView::scrollContentsSlowPath(const IntRect& updateRect)
if (isEnclosedInCompositingLayer()) {
LayoutRect rect(frameLayoutObject->borderLeft() + frameLayoutObject->paddingLeft(),
frameLayoutObject->borderTop() + frameLayoutObject->paddingTop(),
- visibleWidth(), visibleHeight());
+ LayoutUnit(visibleWidth()), LayoutUnit(visibleHeight()));
// FIXME: We should not allow paint invalidation out of paint invalidation state. crbug.com/457415
DisablePaintInvalidationStateAsserts disabler;
frameLayoutObject->invalidatePaintRectangle(rect);
@@ -2717,7 +2717,7 @@ void FrameView::forceLayoutForPagination(const FloatSize& pageSize, const FloatS
LayoutUnit docLogicalHeight = horizontalWritingMode ? updatedDocumentRect.height() : updatedDocumentRect.width();
LayoutUnit docLogicalTop = horizontalWritingMode ? updatedDocumentRect.y() : updatedDocumentRect.x();
LayoutUnit docLogicalRight = horizontalWritingMode ? updatedDocumentRect.maxX() : updatedDocumentRect.maxY();
- LayoutUnit clippedLogicalLeft = 0;
+ LayoutUnit clippedLogicalLeft;
if (!layoutView->style()->isLeftToRightDirection())
clippedLogicalLeft = docLogicalRight - pageLogicalWidth;
LayoutRect overflow(clippedLogicalLeft, docLogicalTop, pageLogicalWidth, docLogicalHeight);
« no previous file with comments | « third_party/WebKit/Source/core/fetch/ImageResource.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698