third_party/WebKit/Source/core/editing/SelectionEditor.cpp - Issue 1653673002: Even more explicit LayoutUnit conversion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/SelectionEditor.cpp

Issue 1653673002: Even more explicit LayoutUnit conversion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@moarConstructors

Patch Set: address comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/SelectionEditor.cpp

diff --git a/third_party/WebKit/Source/core/editing/SelectionEditor.cpp b/third_party/WebKit/Source/core/editing/SelectionEditor.cpp

index bc36df3dc1fa2a2e5330d32334f994ed5ed1c740..227147b3c3d7579ca7c518be20eb9b6412eae848 100644

--- a/third_party/WebKit/Source/core/editing/SelectionEditor.cpp

+++ b/third_party/WebKit/Source/core/editing/SelectionEditor.cpp

@@ -693,7 +693,7 @@ bool SelectionEditor::modify(EAlteration alter, unsigned verticalDistance, Verti

willBeModified(alter, direction == FrameSelection::DirectionUp ? DirectionBackward : DirectionForward);

VisiblePosition pos;

- LayoutUnit xPos = 0;

+ LayoutUnit xPos;

switch (alter) {

case FrameSelection::AlterationMove:

pos = createVisiblePosition(direction == FrameSelection::DirectionUp ? m_selection.start() : m_selection.end(), m_selection.affinity());

@@ -778,7 +778,7 @@ static int lineDirectionPointForBlockDirectionNavigationOf(const VisiblePosition

LayoutUnit SelectionEditor::lineDirectionPointForBlockDirectionNavigation(EPositionType type)

{

- LayoutUnit x = 0;

+ LayoutUnit x;

if (m_selection.isNone())

return x;