Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutMedia.cpp

Issue 1653673002: Even more explicit LayoutUnit conversion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@moarConstructors
Patch Set: Rebased Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutMedia.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutMedia.cpp b/third_party/WebKit/Source/core/layout/LayoutMedia.cpp
index dddb3e24d99ebd556730b865256942e3a5ce6444..2d653aa3dc00eafbc9b1658b2b312b79a265d18d 100644
--- a/third_party/WebKit/Source/core/layout/LayoutMedia.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutMedia.cpp
@@ -77,7 +77,7 @@ void LayoutMedia::layout()
continue;
LayoutBox* layoutBox = toLayoutBox(child);
- layoutBox->setLocation(LayoutPoint(borderLeft(), borderTop()) + LayoutSize(paddingLeft(), paddingTop()));
+ layoutBox->setLocation(LayoutPoint(LayoutUnit(borderLeft()), borderTop()) + LayoutSize(paddingLeft(), paddingTop()));
eae 2016/01/30 05:18:36 Isn't this exactly what contentBoxOffset() does (r
leviw_travelin_and_unemployed 2016/01/30 05:36:06 Awesome point :D
// TODO(philipj): Remove the mutableStyleRef() and depend on CSS
// width/height: inherit to match the media element size.
layoutBox->mutableStyleRef().setHeight(Length(newSize.height(), Fixed));

Powered by Google App Engine
This is Rietveld 408576698