third_party/WebKit/Source/core/fetch/ImageResource.cpp - Issue 1653673002: Even more explicit LayoutUnit conversion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/ImageResource.cpp

Issue 1653673002: Even more explicit LayoutUnit conversion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@moarConstructors

Patch Set: Rebased Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/fetch/ImageResource.cpp

diff --git a/third_party/WebKit/Source/core/fetch/ImageResource.cpp b/third_party/WebKit/Source/core/fetch/ImageResource.cpp

index c7851237e61ce149a67e32797efea295bf8265f4..dabc3d85cc96d7317d73a30c15a59e0c87a71206 100644

--- a/third_party/WebKit/Source/core/fetch/ImageResource.cpp

+++ b/third_party/WebKit/Source/core/fetch/ImageResource.cpp

@@ -228,7 +228,7 @@ LayoutSize ImageResource::imageSize(RespectImageOrientationEnum shouldRespectIma

// Don't let images that have a width/height >= 1 shrink below 1 when zoomed.

float widthScale = m_image->hasRelativeSize() ? 1.0f : multiplier;

float heightScale = m_image->hasRelativeSize() ? 1.0f : multiplier;

- LayoutSize minimumSize(size.width() > 0 ? 1 : 0, size.height() > 0 ? 1 : 0);

+ LayoutSize minimumSize(LayoutUnit(size.width() > 0 ? 1 : 0), LayoutUnit(size.height() > 0 ? 1 : 0));

eae 2016/01/30 05:18:36 LayoutSize minimumSize(size.width() > LayoutUnit()

leviw_travelin_and_unemployed 2016/01/30 05:36:06 Works for me :)

size.scale(widthScale, heightScale);

size.clampToMinimumSize(minimumSize);

ASSERT(multiplier != 1.0f || (size.width().fraction() == 0.0f && size.height().fraction() == 0.0f));