Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 165363002: Fixing a few crashes in the me2me native messaging host. (Closed)

Created:
6 years, 10 months ago by weitao
Modified:
6 years, 10 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fixing a few crashes in the me2me native messaging host. 1. Don't close the delegate read/write handles twice in the me2me native messaging host. The handles are already closed by the native messaging channel in DuplicateHandle. 2. Keep the host alive and send a false response to the client if the user rejects the UAC request. 3. Added some comments. BUG=325567 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251529

Patch Set 1 #

Patch Set 2 : Keey the host alive after the user rejects the UAC request #

Patch Set 3 : Fix mac build break. #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -27 lines) Patch
M remoting/host/setup/me2me_native_messaging_host.h View 1 2 chunks +15 lines, -5 lines 0 comments Download
M remoting/host/setup/me2me_native_messaging_host.cc View 1 2 9 chunks +31 lines, -22 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
weitao
Simple bug fix. PTAL.
6 years, 10 months ago (2014-02-13 23:49:20 UTC) #1
weitao
On 2014/02/13 23:49:20, weitaosu wrote: > Simple bug fix. PTAL. Actually please hold off reviewing ...
6 years, 10 months ago (2014-02-14 00:48:00 UTC) #2
weitao
The CL now contains two bug fixes in DelegateToElevatedHost. Both are pretty scoped so it ...
6 years, 10 months ago (2014-02-14 18:57:17 UTC) #3
Sergey Ulanov
LGTM. Please add a short title in the description before the details. I.e. normally CL ...
6 years, 10 months ago (2014-02-14 19:26:00 UTC) #4
weitao
The CQ bit was checked by weitaosu@chromium.org
6 years, 10 months ago (2014-02-14 22:05:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weitaosu@chromium.org/165363002/40001
6 years, 10 months ago (2014-02-14 22:09:56 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 22:43:49 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=227407
6 years, 10 months ago (2014-02-14 22:43:49 UTC) #8
weitao
The CQ bit was checked by weitaosu@chromium.org
6 years, 10 months ago (2014-02-15 01:10:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weitaosu@chromium.org/165363002/350001
6 years, 10 months ago (2014-02-15 01:12:58 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-02-15 05:08:05 UTC) #11
Message was sent while issue was closed.
Change committed as 251529

Powered by Google App Engine
This is Rietveld 408576698