Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Side by Side Diff: test/vm_test.dart

Issue 1653603002: pkg/stack_trace: Use StackTrace.current (Closed) Base URL: https://github.com/dart-lang/stack_trace.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« pubspec.yaml ('K') | « test/trace_test.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /// This file tests stack_trace's ability to parse live stack traces. It's a 5 /// This file tests stack_trace's ability to parse live stack traces. It's a
6 /// dual of dartium_test.dart, since method names can differ somewhat from 6 /// dual of dartium_test.dart, since method names can differ somewhat from
7 /// platform to platform. No similar file exists for dart2js since the specific 7 /// platform to platform. No similar file exists for dart2js since the specific
8 /// method names there are implementation details. 8 /// method names there are implementation details.
9 @TestOn('vm') 9 @TestOn('vm')
10 10
11 import 'package:path/path.dart' as path; 11 import 'package:path/path.dart' as path;
12 import 'package:stack_trace/stack_trace.dart'; 12 import 'package:stack_trace/stack_trace.dart';
13 import 'package:test/test.dart'; 13 import 'package:test/test.dart';
14 14
15 String getStackTraceString() { 15 String getStackTraceString() => StackTrace.current.toString();
16 try {
17 throw '';
18 } catch (_, stackTrace) {
19 return stackTrace.toString();
20 }
21 }
22 16
23 StackTrace getStackTraceObject() { 17 StackTrace getStackTraceObject() => StackTrace.current;
nweiz 2016/02/01 19:56:29 Just replace the call sites for these functions.
kevmoo 2016/02/01 22:20:07 Done.
24 try {
25 throw '';
26 } catch (_, stackTrace) {
27 return stackTrace;
28 }
29 }
30 18
31 Frame getCaller([int level]) { 19 Frame getCaller([int level]) {
32 if (level == null) return new Frame.caller(); 20 if (level == null) return new Frame.caller();
33 return new Frame.caller(level); 21 return new Frame.caller(level);
34 } 22 }
35 23
36 Frame nestedGetCaller(int level) => getCaller(level); 24 Frame nestedGetCaller(int level) => getCaller(level);
37 25
38 Trace getCurrentTrace([int level]) => new Trace.current(level); 26 Trace getCurrentTrace([int level]) => new Trace.current(level);
39 27
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 100
113 test('at level 2 returns the grandparent frame', () { 101 test('at level 2 returns the grandparent frame', () {
114 expect(nestedGetCaller(2).member, equals('main.<fn>.<fn>')); 102 expect(nestedGetCaller(2).member, equals('main.<fn>.<fn>'));
115 }); 103 });
116 104
117 test('throws an ArgumentError for negative levels', () { 105 test('throws an ArgumentError for negative levels', () {
118 expect(() => new Frame.caller(-1), throwsArgumentError); 106 expect(() => new Frame.caller(-1), throwsArgumentError);
119 }); 107 });
120 }); 108 });
121 } 109 }
OLDNEW
« pubspec.yaml ('K') | « test/trace_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698