Issue 16536: Experimental: a grab bag of support for register allocation. Push the...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16536: Experimental: a grab bag of support for register allocation. Push the... (Closed)

Created:
11 years, 11 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/toiger/

Visibility:
Public.

Description

Experimental: a grab bag of support for register allocation. Push the register allocator through debugger statements, function literals, conditional expressions, loading from and storing to any slot type, and properties. Committed: http://code.google.com/p/v8/source/detail?r=1032

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 3

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -71 lines)			Patch
	M	src/codegen-ia32.cc	View	1	17 chunks	+88 lines, -71 lines	3 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

11 years, 11 months ago (2009-01-06 14:40:26 UTC) #2

LGTM, with comments.

http://codereview.chromium.org/16536/diff/401/8
File src/codegen-ia32.cc (right):

http://codereview.chromium.org/16536/diff/401/8#newcode2626
Line 2626: __ mov(temp.reg(), SlotOperand(slot, temp.reg()));
This was __mov(eax, SlotOperand(slot, ecx)).
What is ecx, and why has it been replaced by temp.reg()?
Isn't it something different than eax?

http://codereview.chromium.org/16536/diff/401/8#newcode2645
Line 2645: __ mov(temp.reg(), SlotOperand(slot, temp.reg()));
Same here, second arg of SlotOperand() was ecx.

http://codereview.chromium.org/16536/diff/401/8#newcode2696
Line 2696: __ mov(temp.reg(), SlotOperand(slot, temp.reg()));
Same, ecx versus eax.

Expand Messages | Collapse Messages