chrome/browser/local_discovery/service_discovery_client.h - Issue 1653573003: Revert of Migrate Local Discovery from net::IPAddressNumber to net::IPAddress.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/local_discovery/service_discovery_client.h

Issue 1653573003: Revert of Migrate Local Discovery from net::IPAddressNumber to net::IPAddress. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/local_discovery/local_domain_resolver_unittest.cc ('k') | chrome/browser/local_discovery/service_discovery_client_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/local_discovery/service_discovery_client.h

diff --git a/chrome/browser/local_discovery/service_discovery_client.h b/chrome/browser/local_discovery/service_discovery_client.h

index b01feba3eb3a3633e93db5c12f6083ea11441126..13f1ece0b34b0f70741a8a96bf8cbfd3722c6ad7 100644

--- a/chrome/browser/local_discovery/service_discovery_client.h

+++ b/chrome/browser/local_discovery/service_discovery_client.h

@@ -13,7 +13,7 @@

#include "base/time/time.h"

#include "net/base/address_family.h"

#include "net/base/host_port_pair.h"

-#include "net/base/ip_address.h"

+#include "net/base/ip_address_number.h"

namespace net {

class MDnsClient;

@@ -38,7 +38,7 @@

// The metadata (from TXT record) of the service.

std::vector<std::string> metadata;

// IP address of the service, if available from cache. May be empty.

- net::IPAddress ip_address;

+ net::IPAddressNumber ip_address;

// Last time the service was seen.

base::Time last_seen;

};

@@ -100,8 +100,8 @@

class LocalDomainResolver {

public:

typedef base::Callback<void(bool /*success*/,

- const net::IPAddress& /*address_ipv4*/,

- const net::IPAddress& /*address_ipv6*/)>

+ const net::IPAddressNumber& /*address_ipv4*/,

+ const net::IPAddressNumber& /*address_ipv6*/)>

IPAddressCallback;

virtual ~LocalDomainResolver() {}