blimp: Use remote client LayerTreeHost in the BlimpCompositor.

blimp: Use remote client LayerTreeHost in the BlimpCompositor.

-Process INITIALIZE_IMPL AND CLOSE_IMPL messages from the compositor to
 create and destroy the remote client LayerTreeHost.
-Send viewport and size updates only to the engine.

BUG=568511
Committed: https://crrev.com/5e8d87bb99cd249eeb286ee5d73f8987d70c9f8b
Cr-Commit-Position: refs/heads/master@{#373470}

[Khushal, 2016-01-29 23:03:42]

khushalsagar@chromium.org changed reviewers:
+ dtrainor@chromium.org

[Khushal, 2016-01-30 02:27:05]

Description was changed from

==========
blimp: Use remote client LayerTreeHost in the BlimpCompositor.

-Process INITIALIZE_IMPL AND CLOSE_IMPL messages from the compositor to
 create and destroy the remote client LayerTreeHost.
-Send viewport and size updates only to the engine.

BUG=568511
==========

to

==========
blimp: Use remote client LayerTreeHost in the BlimpCompositor.

-Process INITIALIZE_IMPL AND CLOSE_IMPL messages from the compositor to
 create and destroy the remote client LayerTreeHost.
-Send viewport and size updates only to the engine.

BUG=568511
==========

[David Trainor- moved to gerrit, 2016-02-02 03:20:16]

lgtm

[Khushal, 2016-02-03 08:54:00]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-03 08:54:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1653553002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1653553002/40001

[commit-bot: I haz the power, 2016-02-03 10:01:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-03 10:01:15]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[David Trainor- moved to gerrit, 2016-02-03 17:42:57]

lgtm!

https://codereview.chromium.org/1653553002/diff/40001/blimp/client/feature/co...
File blimp/client/feature/compositor/blimp_compositor_unittest.cc (right):

https://codereview.chromium.org/1653553002/diff/40001/blimp/client/feature/co...
blimp/client/feature/compositor/blimp_compositor_unittest.cc:36: bool request()
const { return output_surface_request_pending_; }
Looks like you don't use this?

https://codereview.chromium.org/1653553002/diff/40001/blimp/client/feature/co...
blimp/client/feature/compositor/blimp_compositor_unittest.cc:46:
EXPECT_CALL(render_widget_feature_, RemoveDelegate(_)).Times(1);
huh.  why is this called?

[Khushal, 2016-02-03 17:55:52]

On 2016/02/03 17:42:57, David Trainor wrote:
> lgtm!
> 
>
https://codereview.chromium.org/1653553002/diff/40001/blimp/client/feature/co...
> File blimp/client/feature/compositor/blimp_compositor_unittest.cc (right):
> 
>
https://codereview.chromium.org/1653553002/diff/40001/blimp/client/feature/co...
> blimp/client/feature/compositor/blimp_compositor_unittest.cc:36: bool
request()
> const { return output_surface_request_pending_; }
> Looks like you don't use this?
> 
>
https://codereview.chromium.org/1653553002/diff/40001/blimp/client/feature/co...
> blimp/client/feature/compositor/blimp_compositor_unittest.cc:46:
> EXPECT_CALL(render_widget_feature_, RemoveDelegate(_)).Times(1);
> huh.  why is this called?

Thanks!
I've tested this locally but for some reason the test is failing on the bot. :|
I'll take a look.

[Khushal, 2016-02-03 17:56:03]

https://codereview.chromium.org/1653553002/diff/40001/blimp/client/feature/co...
File blimp/client/feature/compositor/blimp_compositor_unittest.cc (right):

https://codereview.chromium.org/1653553002/diff/40001/blimp/client/feature/co...
blimp/client/feature/compositor/blimp_compositor_unittest.cc:36: bool request()
const { return output_surface_request_pending_; }
On 2016/02/03 17:42:57, David Trainor wrote:
> Looks like you don't use this?

Oops. I'll remove this.

https://codereview.chromium.org/1653553002/diff/40001/blimp/client/feature/co...
blimp/client/feature/compositor/blimp_compositor_unittest.cc:46:
EXPECT_CALL(render_widget_feature_, RemoveDelegate(_)).Times(1);
On 2016/02/03 17:42:57, David Trainor wrote:
> huh.  why is this called?

We do that in the dtor. Because the delegate is dying so we make sure we clean
up.

[Khushal, 2016-02-03 19:07:35]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-03 19:10:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1653553002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1653553002/60001

[commit-bot: I haz the power, 2016-02-03 20:31:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-03 20:31:22]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Khushal, 2016-02-03 22:48:38]

The CQ bit was checked by khushalsagar@chromium.org

[Khushal, 2016-02-03 22:48:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/1653553002/#ps80001
(title: "Fix widget initialization")

[commit-bot: I haz the power, 2016-02-03 22:50:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1653553002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1653553002/80001

[commit-bot: I haz the power, 2016-02-03 23:29:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-03 23:29:48]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[Khushal, 2016-02-04 04:09:42]

The CQ bit was checked by khushalsagar@chromium.org

[Khushal, 2016-02-04 04:09:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/1653553002/#ps100001
(title: "Run tests for linux only for now.")

[commit-bot: I haz the power, 2016-02-04 04:10:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1653553002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1653553002/100001

[commit-bot: I haz the power, 2016-02-04 05:47:11]

Description was changed from

==========
blimp: Use remote client LayerTreeHost in the BlimpCompositor.

-Process INITIALIZE_IMPL AND CLOSE_IMPL messages from the compositor to
 create and destroy the remote client LayerTreeHost.
-Send viewport and size updates only to the engine.

BUG=568511
==========

to

==========
blimp: Use remote client LayerTreeHost in the BlimpCompositor.

-Process INITIALIZE_IMPL AND CLOSE_IMPL messages from the compositor to
 create and destroy the remote client LayerTreeHost.
-Send viewport and size updates only to the engine.

BUG=568511
==========

[commit-bot: I haz the power, 2016-02-04 05:47:12]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-02-04 05:48:28]

Description was changed from

==========
blimp: Use remote client LayerTreeHost in the BlimpCompositor.

-Process INITIALIZE_IMPL AND CLOSE_IMPL messages from the compositor to
 create and destroy the remote client LayerTreeHost.
-Send viewport and size updates only to the engine.

BUG=568511
==========

to

==========
blimp: Use remote client LayerTreeHost in the BlimpCompositor.

-Process INITIALIZE_IMPL AND CLOSE_IMPL messages from the compositor to
 create and destroy the remote client LayerTreeHost.
-Send viewport and size updates only to the engine.

BUG=568511

Committed: https://crrev.com/5e8d87bb99cd249eeb286ee5d73f8987d70c9f8b
Cr-Commit-Position: refs/heads/master@{#373470}
==========

[commit-bot: I haz the power, 2016-02-04 05:48:29]

Patchset 6 (id:??) landed as
https://crrev.com/5e8d87bb99cd249eeb286ee5d73f8987d70c9f8b
Cr-Commit-Position: refs/heads/master@{#373470}