tools/flags/SkCommonFlags.h - Issue 1653543002: Revert of Treat bad values passed to --images as a fatal error

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/flags/SkCommonFlags.h

Issue 1653543002: Revert of Treat bad values passed to --images as a fatal error (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright 2014 Google Inc.	2 * Copyright 2014 Google Inc.

3 *	3 *

4 * Use of this source code is governed by a BSD-style license that can be	4 * Use of this source code is governed by a BSD-style license that can be

5 * found in the LICENSE file.	5 * found in the LICENSE file.

6 */	6 */

7	7

8 #ifndef SK_COMMON_FLAGS_H	8 #ifndef SK_COMMON_FLAGS_H

9 #define SK_COMMON_FLAGS_H	9 #define SK_COMMON_FLAGS_H

10	10

11 #include "SkCommandLineFlags.h"	11 #include "SkCommandLineFlags.h"

12 #include "SkTArray.h"

13 #include "SkString.h"

14	12

15 DECLARE_bool(cpu);	13 DECLARE_bool(cpu);

16 DECLARE_bool(dryRun);	14 DECLARE_bool(dryRun);

17 DECLARE_bool(gpu);	15 DECLARE_bool(gpu);

18 DECLARE_string(images);	16 DECLARE_string(images);

19 DECLARE_string(match);	17 DECLARE_string(match);

20 DECLARE_bool(quiet);	18 DECLARE_bool(quiet);

21 DECLARE_bool(resetGpuContext);	19 DECLARE_bool(resetGpuContext);

22 DECLARE_bool(preAbandonGpuContext);	20 DECLARE_bool(preAbandonGpuContext);

23 DECLARE_bool(abandonGpuContext);	21 DECLARE_bool(abandonGpuContext);

24 DECLARE_string(skps);	22 DECLARE_string(skps);

25 DECLARE_int32(threads);	23 DECLARE_int32(threads);

26 DECLARE_string(resourcePath);	24 DECLARE_string(resourcePath);

27 DECLARE_bool(verbose);	25 DECLARE_bool(verbose);

28 DECLARE_bool(veryVerbose);	26 DECLARE_bool(veryVerbose);

29 DECLARE_string(writePath);	27 DECLARE_string(writePath);

30 DECLARE_bool(pre_log);	28 DECLARE_bool(pre_log);

31	29

32 DECLARE_string(key);	30 DECLARE_string(key);

33 DECLARE_string(properties);	31 DECLARE_string(properties);

34	32

35 /**

36 * Helper to assist in collecting image paths from --images.

37 *

38 * Populates an array of strings with paths to images to test.

39 *

40 * Returns true if each argument to --images is meaningful:

41 * - If the file/directory does not exist, return false.

42 * - If a directory passed to --images does not have any supported images (base d on file

43 * type), return false.

44 * - If a file is passed to --images, assume the user is deliberately testing t his image,

45 * regardless of file type.

46 */

47 bool CollectImages(SkTArray<SkString>*);

48

49 #endif	33 #endif

OLD	NEW

« no previous file with comments | « gyp/common_variables.gypi ('k') | tools/flags/SkCommonFlags.cpp » ('j') | no next file with comments »