Docserver: Fix invalid path usage in CloudStorageFileSystem.

chrome/common/extensions/docs/server2/file_system.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import posixpath
 import traceback
 
 from future import Gettable, Future
-from path_util import AssertIsDirectory, AssertIsValid, SplitParent, ToDirectory
+from path_util import (
+    AssertIsDirectory, AssertIsValid, IsDirectory, IsValid, SplitParent,
+    ToDirectory)
 
 
 class _BaseFileSystemException(Exception):
   def __init__(self, message):
     Exception.__init__(self, message)
 
   @classmethod
   def RaiseInFuture(cls, message):
     stack = traceback.format_stack()
     def boom(): raise cls('%s. Creation stack:\n%s' % (message, ''.join(stack)))
@@ skipping 12 matching lines @@
   network timeout.
   '''
   def __init__(self, filename):
     _BaseFileSystemException.__init__(self, filename)
 
 
 class StatInfo(object):
   '''The result of calling Stat on a FileSystem.
   '''
   def __init__(self, version, child_versions=None):
+    if child_versions:
+      assert all(IsValid(path) for path in child_versions.iterkeys()), \
+             child_versions
     self.version = version
     self.child_versions = child_versions
 
   def __eq__(self, other):
     return (isinstance(other, StatInfo) and
             self.version == other.version and
             self.child_versions == other.child_versions)
 
   def __ne__(self, other):
     return not (self == other)
@@ skipping 93 matching lines @@
     For any other failure, raises a FileSystemError.
     '''
     AssertIsDirectory(root)
     basepath = root
 
     def walk(root):
       AssertIsDirectory(root)
       dirs, files = [], []
 
       for f in self.ReadSingle(root).Get():
-        if f.endswith('/'):
+        if IsDirectory(f):
           dirs.append(f)
         else:
           files.append(f)
 
       yield root[len(basepath):].rstrip('/'), dirs, files
 
       for d in dirs:
         for walkinfo in walk(root + d):
           yield walkinfo
 
     for walkinfo in walk(root):
       yield walkinfo
 
   def __repr__(self):
     return '<%s>' % type(self).__name__
 
   def __str__(self):
     return repr(self)