Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 165353: Merge 21668 - Make AutomationProxyTest.NavigateToURLWithTimeout* tests notfla... (Closed)

Created:
11 years, 4 months ago by laforge
Modified:
9 years, 7 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Merge 21668 - Make AutomationProxyTest.NavigateToURLWithTimeout* tests notflaky. I used a mock url request job which is guaranteed to finish after the timeout the test uses. TEST=none http://crbug.com/16462 Review URL: http://codereview.chromium.org/155941 TBR=phajdan.jr@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23130

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -16 lines) Patch
MM chrome/browser/automation/automation_provider.cc View 2 chunks +2 lines, -0 lines 0 comments Download
MM chrome/browser/automation/url_request_mock_http_job.h View 1 chunk +5 lines, -0 lines 0 comments Download
MM chrome/browser/automation/url_request_mock_http_job.cc View 2 chunks +24 lines, -16 lines 0 comments Download
A + chrome/browser/automation/url_request_slow_http_job.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/automation/url_request_slow_http_job.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
MM chrome/chrome.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/test/automation/automation_proxy_uitest.cc View 3 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
laforge
11 years, 4 months ago (2009-08-12 00:39:57 UTC) #1
Paweł Hajdan Jr.
11 years, 4 months ago (2009-08-12 15:34:21 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698