Issue 165353: Merge 21668 - Make AutomationProxyTest.NavigateToURLWithTimeout* tests notfla...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 165353: Merge 21668 - Make AutomationProxyTest.NavigateToURLWithTimeout* tests notfla... (Closed)

Created:
11 years, 4 months ago by laforge

Modified:
9 years, 7 months ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/branches/195/src/

Visibility:
Public.

Merge 21668 - Make AutomationProxyTest.NavigateToURLWithTimeout* tests notflaky. I used a mock url request job which is guaranteed to finish after the timeout the test uses. TEST=none http://crbug.com/16462 Review URL: http://codereview.chromium.org/155941 TBR=phajdan.jr@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23130

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -16 lines)			Patch
MM	chrome/browser/automation/automation_provider.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
MM	chrome/browser/automation/url_request_mock_http_job.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
MM	chrome/browser/automation/url_request_mock_http_job.cc	View	2 chunks	+24 lines, -16 lines	0 comments	Download
A +	chrome/browser/automation/url_request_slow_http_job.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/automation/url_request_slow_http_job.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
MM	chrome/chrome.gyp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
MM	chrome/test/automation/automation_proxy_uitest.cc	View	3 chunks	+16 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM