Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1653453002: Don't use "var" to introduce the deferred_initializer. (Closed)

Created:
4 years, 10 months ago by floitsch
Modified:
4 years, 10 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't use "var" to introduce the deferred_initializer. R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/2232803eae7b0b288093f33f90460e4e096758f5

Patch Set 1 #

Patch Set 2 : Add test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -9 lines) Patch
M pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/native/native.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + tests/compiler/dart2js_extra/deferred_custom_loader_lib.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
A tests/compiler/dart2js_extra/deferred_custom_loader_test.dart View 1 1 chunk +36 lines, -0 lines 0 comments Download
M tests/language/deferred_type_dependency_test.dart View 1 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
floitsch
4 years, 10 months ago (2016-01-29 20:49:45 UTC) #2
Harry Terkelsen
lgtm
4 years, 10 months ago (2016-01-29 20:51:36 UTC) #3
floitsch
4 years, 10 months ago (2016-01-29 20:52:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2232803eae7b0b288093f33f90460e4e096758f5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698